Skip to content

32989 ipa file parsing and upload software endpoint - #34014

Merged
jahzielv merged 11 commits into
feat-in-house-appsfrom
32989-ipa-file-parsing
Oct 9, 2025
Merged

32989 ipa file parsing and upload software endpoint#34014
jahzielv merged 11 commits into
feat-in-house-appsfrom
32989-ipa-file-parsing

Conversation

@jkatz01

@jkatz01 jkatz01 commented Oct 8, 2025

Copy link
Copy Markdown
Member

Related issue: Resolves #32944 #32989

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

@jkatz01
jkatz01 requested a review from a team as a code owner October 8, 2025 19:46
@codecov

codecov Bot commented Oct 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.17687% with 85 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat-in-house-apps@7f839be). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/file/ipa.go 0.00% 44 Missing ⚠️
server/datastore/mysql/software_installers.go 65.07% 17 Missing and 5 partials ⚠️
server/datastore/mysql/in_house_apps.go 64.00% 6 Missing and 3 partials ⚠️
ee/server/service/software_installers.go 33.33% 5 Missing and 1 partial ⚠️
pkg/file/file.go 0.00% 2 Missing ⚠️
server/fleet/software_installer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat-in-house-apps   #34014   +/-   ##
=====================================================
  Coverage                      ?   64.19%           
=====================================================
  Files                         ?     2057           
  Lines                         ?   206681           
  Branches                      ?     6754           
=====================================================
  Hits                          ?   132670           
  Misses                        ?    63598           
  Partials                      ?    10413           
Flag Coverage Δ
backend 65.28% <42.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkatz01
jkatz01 marked this pull request as draft October 8, 2025 20:34
@jkatz01
jkatz01 marked this pull request as ready for review October 9, 2025 15:04
@jkatz01
jkatz01 requested a review from jahzielv October 9, 2025 15:46
@jahzielv
jahzielv merged commit 056ae89 into feat-in-house-apps Oct 9, 2025
41 checks passed
@jahzielv
jahzielv deleted the 32989-ipa-file-parsing branch October 9, 2025 16:08
@jahzielv

jahzielv commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Meant to approve this before merging, my bad! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update POST /api/v1/fleet/software/package to accept .ipa extensions

3 participants