Skip to content

32989: basic DB setup - #33938

Merged
jahzielv merged 6 commits into
feat-in-house-appsfrom
32989-ipa-data-structure
Oct 7, 2025
Merged

32989: basic DB setup#33938
jahzielv merged 6 commits into
feat-in-house-appsfrom
32989-ipa-data-structure

Conversation

@jahzielv

@jahzielv jahzielv commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Fixes #32989 (partially)

  • initial db setup
  • basic crud method

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

Database migrations

  • Checked table schema to confirm autoupdate
  • Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

@jahzielv jahzielv changed the title 32989 ipa data structure 32989: basic DB setup Oct 7, 2025
@codecov

codecov Bot commented Oct 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.87850% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.15%. Comparing base (b0866dc) to head (edba3a2).
⚠️ Report is 23 commits behind head on feat-in-house-apps.

Files with missing lines Patch % Lines
pkg/file/file.go 0.00% 18 Missing ⚠️
server/datastore/mysql/in_house_apps.go 69.23% 10 Missing and 2 partials ⚠️
...ations/tables/20251006163522_InHouseAppsSupport.go 81.81% 6 Missing and 2 partials ⚠️
ee/server/service/software_installers.go 0.00% 3 Missing and 1 partial ⚠️
server/fleet/software_installer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat-in-house-apps   #33938    +/-   ##
====================================================
  Coverage               64.15%   64.15%            
====================================================
  Files                    2052     2054     +2     
  Lines                  206257   206477   +220     
  Branches                 6751     6751            
====================================================
+ Hits                   132321   132465   +144     
- Misses                  63543    63604    +61     
- Partials                10393    10408    +15     
Flag Coverage Δ
backend 65.27% <58.87%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahzielv
jahzielv marked this pull request as ready for review October 7, 2025 17:05
@jahzielv
jahzielv requested a review from a team as a code owner October 7, 2025 17:05

@mna mna left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Looks good, one small nit for the PK.

Comment thread server/datastore/mysql/migrations/tables/20251006163522_InHouseAppsSupport.go Outdated
@jahzielv
jahzielv merged commit ad335a8 into feat-in-house-apps Oct 7, 2025
35 checks passed
@jahzielv
jahzielv deleted the 32989-ipa-data-structure branch October 7, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants