Skip to content

Sort found variables by length descending - #33875

Merged
MagnusHJensen merged 1 commit into
mainfrom
33502-longer-vars-not-processed-in-right-order
Oct 6, 2025
Merged

Sort found variables by length descending#33875
MagnusHJensen merged 1 commit into
mainfrom
33502-longer-vars-not-processed-in-right-order

Conversation

@MagnusHJensen

Copy link
Copy Markdown
Member

Related issue: Resolves #33502

This fixes the mentioned issue by always sorting the found variables in length descending, to ensure we process the longest variables first, avoiding us processing a smaller variation of a longer variable first breaking substitution.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

@MagnusHJensen
MagnusHJensen requested a review from a team as a code owner October 6, 2025 16:56
@codecov

codecov Bot commented Oct 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.14%. Comparing base (e393c1a) to head (6d623c3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33875      +/-   ##
==========================================
+ Coverage   64.13%   64.14%   +0.01%     
==========================================
  Files        2052     2052              
  Lines      206102   206241     +139     
  Branches     6847     6847              
==========================================
+ Hits       132183   132295     +112     
- Misses      63542    63550       +8     
- Partials    10377    10396      +19     
Flag Coverage Δ
backend 65.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MagnusHJensen
MagnusHJensen merged commit a683185 into main Oct 6, 2025
39 checks passed
@MagnusHJensen
MagnusHJensen deleted the 33502-longer-vars-not-processed-in-right-order branch October 6, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fleet variable $FLEET_VAR_HOST_END_USER_IDP_USERNAME_LOCAL_PART not extracting username correctly

2 participants