Skip to content

Use more flexible pattern match instead of fake timers - #33710

Closed
jacobshandling wants to merge 2 commits into
mainfrom
revert-fake-timers
Closed

Use more flexible pattern match instead of fake timers#33710
jacobshandling wants to merge 2 commits into
mainfrom
revert-fake-timers

Conversation

@jacobshandling

@jacobshandling jacobshandling commented Oct 1, 2025

Copy link
Copy Markdown
Contributor
  • Revert commit 85032e8, which caused the test to hang indefinitely
  • Use more flexible matcher

@jacobshandling jacobshandling changed the title Undo https://github.com/fleetdm/fleet/pull/33694 Use more flexible pattern match instead of fake timers Oct 1, 2025
@codecov

codecov Bot commented Oct 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.00%. Comparing base (e235fda) to head (e1ed74a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33710   +/-   ##
=======================================
  Coverage   64.00%   64.00%           
=======================================
  Files        2067     2067           
  Lines      207188   207198   +10     
  Branches     6847     6853    +6     
=======================================
+ Hits       132608   132615    +7     
- Misses      64147    64150    +3     
  Partials    10433    10433           
Flag Coverage Δ
frontend 53.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia RachelElysia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm

@jacobshandling

Copy link
Copy Markdown
Contributor Author

Closing, same fix already merged as part of #33679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants