Removing the software renaming fix introduced in 4.73.3 due to MySQL …

[dantecatalfamo]

…DB performance issues. (#33616)

Needs to be cherry picked into 4.73.4 and/or 4.74.0 and 4.75.0

Related issue: Resolves #33612

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes
  files for more information.

Testing

• Added/updated automated tests
• QA'd all new/changed functionality manually

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.

• Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

• If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

• Added/updated automated tests

• Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)

• QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

• Confirmed that the fix is not expected to adversely impact load test results
• Alerted the release DRI if additional load testing is needed

Database migrations

• Checked table schema to confirm autoupdate
• Checked schema for all modified table for columns that will auto-update timestamps during migration.
• Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
• Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

• Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

• Verified that the setting is exported via fleetctl generate-gitops
• Verified the setting is documented in a separate PR to the GitOps documentation
• Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
• Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

• Verified compatibility with the latest released version of Fleet (see Must rule)
• If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
• Verified that fleetd runs on macOS, Linux and Windows
• Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.01%. Comparing base (bd0dd18) to head (2866181).
⚠️ Report is 10 commits behind head on rc-minor-fleet-v4.74.0.

Files with missing lines	Patch %	Lines
server/datastore/mysql/software.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                     @@
##           rc-minor-fleet-v4.74.0   #33632      +/-   ##
==========================================================
+ Coverage                   58.04%   63.01%   +4.97%     
==========================================================
  Files                        1335     1334       -1     
  Lines                      180831   180972     +141     
==========================================================
+ Hits                       104955   114037    +9082     
+ Misses                      66606    56952    -9654     
- Partials                     9270     9983     +713     

Flag	Coverage Δ
backend	63.01% <66.66%> (+4.97%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.