UI: Linux setup experience - End user by jacobshandling · Pull Request #32639 · fleetdm/fleet

jacobshandling · 2025-09-05T06:05:49Z

PR 2/2 for #32037

Implements update for the Linux setup experience from the end-user's point of view (the "My device" page).
Works in concert with the new endpoints implemented in API endpoints for Linux setup experience #32493
My device page calls a new endpoint to get in-progress setup experience software installations. If there are any, the page is replaced with a "Setting up your device" page
The UI polls this endpoint until all such installations are either successful or failed (including canceled)
Setting up your device page includes a table displaying the name and status of each software installation
Once all installations are finished (succeed/fail), renders the regular My device page
Add a handler for the new API call for relevant tests

Testing

Can use this branch with fake data to help test this PR

Changes file added for user-visible changes in changes/
Added/updated automated tests - additional tests coming in follow-up
QA'd all new/changed functionality manually

codecov · 2025-09-05T17:37:46Z

Codecov Report

❌ Patch coverage is 58.55856% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.99%. Comparing base (86fcdde) to head (d261d5a).
⚠️ Report is 28 commits behind head on main.

Files with missing lines	Patch %	Lines
...etupSoftwareStatusCell/SetupSoftwareStatusCell.tsx	15.78%	16 Missing ⚠️
...es/hosts/details/DeviceUserPage/DeviceUserPage.tsx	74.54%	13 Missing and 1 partial ⚠️
...wareStatusTable/SetupSoftwareStatusTableConfig.tsx	14.28%	6 Missing ⚠️
...upSoftwareStatusTable/SetupSoftwareStatusTable.tsx	33.33%	4 Missing ⚠️
...upSoftwareProcessCell/SetupSoftwareProcessCell.tsx	40.00%	3 Missing ⚠️
...onents/SettingUpYourDevice/SettingUpYourDevice.tsx	50.00%	2 Missing ⚠️
...tend/pages/hosts/details/DeviceUserPage/helpers.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32639      +/-   ##
==========================================
- Coverage   64.02%   63.99%   -0.04%     
==========================================
  Files        2002     2011       +9     
  Lines      198219   198515     +296     
  Branches     6440     6552     +112     
==========================================
+ Hits       126907   127035     +128     
- Misses      61324    61490     +166     
- Partials     9988     9990       +2

Flag	Coverage Δ
frontend	`52.46% <58.55%> (-0.15%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sgress454

code looks good, nuthin but nits so far

attempting a test run now!

sgress454 · 2025-09-05T21:24:40Z

+  "running",
+  "success",
+  "failure",
+  "cancelled", // server should be aggregating cancelled installs with failed, check here just in case


damn, team canceLed takes a hit

There was nothing I could do 😕

fleet/server/fleet/setup_experience.go

Line 15 in ec21637

SetupExperienceStatusCancelled SetupExperienceStatusResultStatus = "cancelled"

i know, don't think i didn't look already 🙃

sgress454 · 2025-09-05T21:35:14Z

                )}
-              </Tabs>
-            </TabNav>
-            {showInfoModal && <InfoModal onCancel={toggleInfoModal} />}


Just curious what the impact of moving this is? Just easier to find in the markup?

the child is not necessarily rendered

in the SettingUpYourDevice case, the previous location of this line would not be rendered, so modal would not be rendered

arguably all of the modals should be moved similarly, but that would blow this up a bit

sgress454 · 2025-09-05T21:44:18Z

+        disablePagination
+        pageSize={statuses.length}
+        emptyComponent={() => (
+          // will never be empty


sgress454 · 2025-09-05T21:44:50Z

+        isAllPagesSelected={false}
+        disableTableHeader={false}
+        disablePagination
+        pageSize={statuses.length}


i'm assuming this page scrolls?

Yea, figured so since pagination was never mentioned

sgress454

tested 👍 , great job!

jacobshandling added 6 commits September 4, 2025 22:54

endpoint, interfaces, polling, conditions for what to display on DUP

1a94ef0

wip

4addb62

wip - SettingUpYourDevice

321d8f6

table

5cae522

changes

0c0a7be

cleanup

98f801d

jacobshandling temporarily deployed to Docker Hub September 5, 2025 06:05 — with GitHub Actions Inactive

jacobshandling added 2 commits September 5, 2025 08:05

improve condition

45b0987

remove fake data/state condition

f268de8

jacobshandling force-pushed the 32037-end-user branch from fcbe05a to f268de8 Compare September 5, 2025 15:15

jacobshandling temporarily deployed to Docker Hub September 5, 2025 15:15 — with GitHub Actions Inactive

add test handler for new API call

558ec5b

jacobshandling temporarily deployed to Docker Hub September 5, 2025 17:35 — with GitHub Actions Inactive

jacobshandling marked this pull request as ready for review September 5, 2025 17:36

jacobshandling requested a review from a team as a code owner September 5, 2025 17:36

jacobshandling assigned sgress454 Sep 5, 2025

jacobshandling linked an issue Sep 5, 2025 that may be closed by this pull request

Linux setup - Frontend #32037

Closed

sgress454 reviewed Sep 5, 2025

View reviewed changes

generalize prop

8d08980

jacobshandling temporarily deployed to Docker Hub September 5, 2025 22:05 — with GitHub Actions Inactive

de-flake a test

d261d5a

jacobshandling temporarily deployed to Docker Hub September 5, 2025 22:45 — with GitHub Actions Inactive

sgress454 approved these changes Sep 5, 2025

View reviewed changes

jacobshandling merged commit 32c60fe into main Sep 5, 2025
15 checks passed

jacobshandling deleted the 32037-end-user branch September 5, 2025 22:53

Uh oh!

Conversation

jacobshandling commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR 2/2 for #32037

Testing

Uh oh!

codecov Bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sgress454 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sgress454 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jacobshandling commented Sep 5, 2025 •

edited

Loading

codecov Bot commented Sep 5, 2025 •

edited

Loading