Apply relevant cleanup suggested by CodeRabbit in #32245 for GitOps update work - #32482
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32482 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 1987 1987
Lines 195632 195630 -2
Branches 6461 6461
=======================================
+ Hits 125248 125249 +1
+ Misses 60579 60577 -2
+ Partials 9805 9804 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iansltx
force-pushed
the
30095-gitops-changes
branch
from
September 1, 2025 21:08
69c4902 to
ecec668
Compare
iansltx
force-pushed
the
30095-cleanup
branch
from
September 2, 2025 13:44
deab5b7 to
3d5ea4c
Compare
iansltx
force-pushed
the
30095-gitops-changes
branch
from
September 2, 2025 21:25
552c868 to
35ec21e
Compare
iansltx
force-pushed
the
30095-cleanup
branch
from
September 2, 2025 21:26
3d5ea4c to
f8c9306
Compare
iansltx
added a commit
that referenced
this pull request
Sep 3, 2025
…e details, update generate-gitops (#32492) For #30095. #32482 is additional cleanup. Merging this to unblock orchestration Linux setup experience work. Code has already been reviewed prior to merging into the feature branch. --------- Co-authored-by: Konstantin Sykulev <konst@sykulev.com> Co-authored-by: Anthony Maxwell <133805840+Illbjorn@users.noreply.github.com>
iansltx
force-pushed
the
30095-cleanup
branch
from
September 3, 2025 18:33
f8c9306 to
bac6d49
Compare
lucasmrod
approved these changes
Sep 3, 2025
Contributor
Author
|
Test failure is 'cuz flakiness and doesn't affec this code at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for submitter