linux vulns API changes by jahzielv · Pull Request #31490 · fleetdm/fleet

jahzielv · 2025-07-31T21:50:21Z

Fixes #31213

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually

Database migrations

Checked table schema to confirm autoupdate

… table

…w software

coderabbitai · 2025-07-31T21:50:29Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 31213-linux-vulns-api-changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-07-31T22:03:00Z

Codecov Report

❌ Patch coverage is 86.45161% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.01%. Comparing base (03a9cc1) to head (920aa08).
⚠️ Report is 1 commits behind head on 30738-linux-vulns.

Files with missing lines	Patch %	Lines
...ns/tables/20250729143159_SoftwareIsKernelColumn.go	73.33%	6 Missing and 2 partials ⚠️
server/service/hosts.go	54.54%	2 Missing and 3 partials ⚠️
...atastore/mysql/operating_system_vulnerabilities.go	95.83%	2 Missing and 2 partials ⚠️
server/service/osquery_utils/queries.go	0.00%	2 Missing and 1 partial ⚠️
server/datastore/mysql/software.go	92.30%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           30738-linux-vulns   #31490      +/-   ##
=====================================================
+ Coverage              64.00%   64.01%   +0.01%     
=====================================================
  Files                   1913     1914       +1     
  Lines                 188316   188445     +129     
  Branches                5629     5629              
=====================================================
+ Hits                  120525   120642     +117     
- Misses                 58332    58341       +9     
- Partials                9459     9462       +3

Flag	Coverage Δ
backend	`64.88% <86.45%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iansltx

Much more minor feedback this time around. Thanks for the cleanup!

iansltx

LGTM. Thanks for the quick turn on the last couple rounds!

- **linux vulns API changes (#31490)** - **31214 linux vulns optimization (#31722)** # Checklist for submitter If some of the following don't apply, delete the relevant line. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) ## Testing - [x] Added/updated automated tests - [x] Where appropriate, [automated tests simulate multiple hosts and test for host isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing) (updates to one hosts's records do not affect another) - [x] QA'd all new/changed functionality manually ## Database migrations - [x] Checked table schema to confirm autoupdate - [x] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [x] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [x] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`).

jahzielv added 4 commits July 28, 2025 17:04

add additional query for getting linux kernel vulns from software_cve…

de99961

… table

add migration

ce0c5bf

check if the software is a kernel and use that flag when we ingest ne…

ce59ccd

…w software

update test, make it pass

b02f309

jahzielv temporarily deployed to Docker Hub July 31, 2025 21:50 — with GitHub Actions Inactive

add backfill to migration, add migration test

2e44649

jahzielv temporarily deployed to Docker Hub August 1, 2025 14:03 — with GitHub Actions Inactive

jahzielv added 2 commits August 1, 2025 10:46

fix test

eefb81f

fix other test

d886a1f

jahzielv temporarily deployed to Docker Hub August 1, 2025 15:55 — with GitHub Actions Inactive

jahzielv added 2 commits August 1, 2025 14:36

move around is_kernel logic, use full list of supported linux distros

28f0328

add entity endpoint missing pieces

5ed8d19

jahzielv temporarily deployed to Docker Hub August 1, 2025 20:27 — with GitHub Actions Inactive

basic test for listing kernels

ffb5c91

jahzielv temporarily deployed to Docker Hub August 1, 2025 21:13 — with GitHub Actions Inactive

update test

d38c32f

jahzielv temporarily deployed to Docker Hub August 1, 2025 23:52 — with GitHub Actions Inactive

update test

62d738d

jahzielv temporarily deployed to Docker Hub August 4, 2025 19:13 — with GitHub Actions Inactive

jahzielv changed the title ~~31213 linux vulns api changes~~ linux vulns API changes Aug 4, 2025

add entity endpoint test

92f1d41

jahzielv temporarily deployed to Docker Hub August 5, 2025 21:25 — with GitHub Actions Inactive

avoid global stats

20a6a75

jahzielv temporarily deployed to Docker Hub August 5, 2025 21:48 — with GitHub Actions Inactive

refactor test, add amazon and rhel hosts

0d1e099

jahzielv had a problem deploying to Docker Hub August 5, 2025 23:08 — with GitHub Actions Error

fix lint

15ce472

jahzielv temporarily deployed to Docker Hub August 5, 2025 23:09 — with GitHub Actions Inactive

jahzielv requested a review from iansltx August 5, 2025 23:10

iansltx reviewed Aug 6, 2025

View reviewed changes

feedback

9c5b944

jahzielv temporarily deployed to Docker Hub August 6, 2025 12:02 — with GitHub Actions Inactive

jahzielv had a problem deploying to Docker Hub August 6, 2025 12:02 — with GitHub Actions Error

update comment

4981a1c

jahzielv temporarily deployed to Docker Hub August 6, 2025 12:04 — with GitHub Actions Inactive

jahzielv requested a review from iansltx August 6, 2025 12:04

iansltx reviewed Aug 6, 2025

View reviewed changes

Comment thread server/service/integration_enterprise_vulns_test.go Outdated

revert change

920aa08

jahzielv temporarily deployed to Docker Hub August 6, 2025 14:16 — with GitHub Actions Inactive

iansltx approved these changes Aug 6, 2025

View reviewed changes

jahzielv merged commit d8332a4 into 30738-linux-vulns Aug 6, 2025
39 checks passed

jahzielv deleted the 31213-linux-vulns-api-changes branch August 6, 2025 14:55

jahzielv mentioned this pull request Aug 14, 2025

30738 linux vulns #31893

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

linux vulns API changes - #31490

linux vulns API changes#31490
jahzielv merged 25 commits into
30738-linux-vulnsfrom
31213-linux-vulns-api-changes

jahzielv commented Jul 31, 2025 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 31, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov Bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

iansltx left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iansltx left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jahzielv commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist for submitter

Testing

Database migrations

Uh oh!

coderabbitai Bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov Bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iansltx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iansltx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jahzielv commented Jul 31, 2025 •

edited

Loading

coderabbitai Bot commented Jul 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov Bot commented Jul 31, 2025 •

edited

Loading