Cherry pick for fix fleetctl generate-gitops when MDM is turned off (#30677) - #30687
Conversation
For unreleased bug #30656. - [X] Added/updated automated tests - [X] Manual QA for all new/changed functionality - [X] For unreleased bug fixes in a release candidate, confirmed that the fix is not expected to adversely impact load test results or alerted the release DRI if additional load testing is needed. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved handling to ensure MDM-related data is only generated when MDM is enabled and properly configured. * Errors related to MDM configuration are now surfaced instead of being silently ignored. * **Tests** * Added new tests to verify correct behavior when MDM is disabled and not configured, ensuring empty or minimal outputs for MDM-related data in this scenario. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fleetctl generate-gitops when MDM is turned off (#30677)fleetctl generate-gitops when MDM is turned off (#30677)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.71.0 #30687 +/- ##
==========================================================
- Coverage 64.11% 62.13% -1.99%
==========================================================
Files 1878 1877 -1
Lines 184499 184523 +24
Branches 5318 5318
==========================================================
- Hits 118295 114654 -3641
- Misses 56896 60684 +3788
+ Partials 9308 9185 -123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For unreleased bug #30656.
Summary by CodeRabbit
Bug Fixes
Improved handling to ensure MDM-related data is only generated when MDM is enabled and properly configured.
Errors related to MDM configuration are now surfaced instead of being silently ignored.
Tests
Added new tests to verify correct behavior when MDM is disabled and not configured, ensuring empty or minimal outputs for MDM-related data in this scenario.