Update 1Password macOS version number to 8.11.0 - #30646
Conversation
WalkthroughThe policy configuration for verifying the 1Password application version on macOS was updated to require a newer minimum version. The minimum acceptable version was changed from 8.10.82 to 8.11.0, with no other modifications to the policy logic or structure. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
it-and-security/lib/macos/policies/update-1password.yml (1)
2-2: Confirm version string granularity (8.11.0vs8.11) to avoid accidental non-complianceSome 1Password 8.11 builds expose
CFBundleShortVersionStringas simply8.11(no trailing.0).
Ifversion_compare()treats8.11<8.11.0, up-to-date hosts will incorrectly fail this policy. Consider relaxing the check:-AND version_compare(bundle_short_version, '8.11.0') >= 0 +AND version_compare(bundle_short_version, '8.11') >= 0Please spot-check a few Macs to confirm the exact version string before merging.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
it-and-security/lib/macos/policies/update-1password.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-binaries
- GitHub Check: publish
- GitHub Check: fleet-gitops
Summary by CodeRabbit