Website: Update software catalog url and mentions. - #30562
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes systematically rename all references to "app library" to "software catalog" throughout the project. This includes updates to route paths, navigation links, metadata, descriptive text, and internal URLs. Redirects are added for legacy paths, and all user-facing content and navigation now reference "software catalog" instead of "app library." Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WebServer
participant Controller
participant View
User->>WebServer: GET /app-library or /app-library/:appIdentifier
WebServer->>WebServer: Redirect to /software-catalog or /software-catalog/:appIdentifier
User->>WebServer: GET /software-catalog
WebServer->>Controller: view-app-library
Controller->>View: Render software catalog page
View-->>User: Display software catalog
User->>WebServer: GET /software-catalog/:appIdentifier
WebServer->>Controller: view-app-details
Controller->>View: Render app details page
View-->>User: Display app details
Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
website/api/controllers/download-sitemap.js (1)
111-113: Per-app URLs in sitemap still point to/app-library
These links will 404 after the rename.- sitemapXml +=`<url><loc>${_.escape(sails.config.custom.baseUrl+`/app-library/${appPage.identifier}`)}</loc></url>`; + sitemapXml +=`<url><loc>${_.escape(sails.config.custom.baseUrl+`/software-catalog/${appPage.identifier}`)}</loc></url>`;
🧹 Nitpick comments (3)
website/assets/js/components/docs-nav-and-search.component.js (1)
76-80: Remove duplicate'software'entry insearchIndexesThatExist
softwareappears twice; it’s harmless but untidy and could mislead future refactors.- let searchIndexesThatExist = ['docs', 'software', 'queries', 'vitals', 'policies', 'tables', 'handbook', 'software']; + let searchIndexesThatExist = ['docs', 'software', 'queries', 'vitals', 'policies', 'tables', 'handbook'];website/views/layouts/layout.ejs (1)
454-455: Script for legacy page name — decide if still needed
app-library.page.jsis still loaded even though the public route is now/software-catalog.
If the JS file has also been renamed or duplicated, update the reference to avoid an extra request / dead code.website/views/pages/app-library.ejs (1)
20-21: Path corrected, but component/page id/name is now misleading
The outer<div id="app-library">and filename still say “app-library”.
Consider renaming to avoid confusion for future contributors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
website/api/controllers/download-sitemap.js(1 hunks)website/api/controllers/view-app-details.js(2 hunks)website/assets/js/components/docs-nav-and-search.component.js(1 hunks)website/config/routes.js(4 hunks)website/views/layouts/layout.ejs(1 hunks)website/views/pages/app-details.ejs(3 hunks)website/views/pages/app-library.ejs(1 hunks)website/views/pages/software-management.ejs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: build-binaries
- GitHub Check: build (20.x)
- GitHub Check: build-and-check
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (go)
🔇 Additional comments (9)
website/views/pages/software-management.ejs (1)
7-7: Copy update correct and consistent
Terminology swap reads well and aligns with the rest of the renaming work.website/assets/js/components/docs-nav-and-search.component.js (1)
42-42: Href update LGTM
Route now points at/software-catalog, matching the new URLs.website/views/layouts/layout.ejs (1)
211-212: Dropdown copy updated correctly
Text now references “software catalog”.website/api/controllers/download-sitemap.js (1)
77-78: Good: overview URL added to sitemapwebsite/views/pages/app-details.ejs (1)
7-7: LGTM! Consistent URL updates across the template.All URL references have been correctly updated from
/app-libraryto/software-catalog, including breadcrumb navigation, internal links, and social share URLs. The changes maintain existing functionality while implementing the new URL structure consistently.Also applies to: 32-32, 55-57
website/api/controllers/view-app-details.js (1)
14-14: LGTM! Terminology correctly updated in comments and metadata.The controller documentation and page metadata have been properly updated to use "software catalog" instead of "app library", maintaining consistency with the rebranding effort. No functional changes, just terminology alignment.
Also applies to: 47-47
website/config/routes.js (3)
403-403: LGTM! Metadata description updated for consistency.The page description has been properly updated to use "software catalog" terminology, maintaining consistency with the overall rebranding effort.
464-474: LGTM! Route paths correctly updated to new URL structure.The route definitions have been properly updated from
/app-libraryto/software-catalogwhile maintaining the same action mappings. The parameterized route for app details correctly preserves the:appIdentifierparameter structure.
726-731: Excellent implementation of backwards compatibility redirects.The redirect implementation properly handles both the main app library route and the parameterized app details route. The redirect function correctly preserves the
appIdentifierparameter when redirecting from/app-library/:appIdentifierto/software-catalog/:appIdentifier, ensuring existing bookmarks and links continue to work.
2 participants
Closes: https://github.com/fleetdm/confidential/issues/10867
Changes:
/software-catalogand added redirects.Summary by CodeRabbit
New Features
Style