Profiles batch activity - #21604
Merged
Merged
Conversation
Member
Author
|
@roperzh, Can you review this PR since it modifies the MDM config profile code? |
Contributor
|
@getvictor thanks so much for the ping, taking a look shortly |
roperzh
previously approved these changes
Aug 30, 2024
roperzh
left a comment
roperzh
left a comment
Contributor
There was a problem hiding this comment.
looks good! is there any way we could enforce that all the statements and functions used to compare entities are updated when somebody adds a new column? it's my only worry
Member
Author
Yes, I can add some tests that use reflection which should catch changes. |
# Conflicts: # server/datastore/mysql/schema.sql
Member
Author
|
Will address migration timestamps in a separate PR. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20757
API endpoint
/api/v1/fleet/mdm/profiles/batchwill now not log an activity for profile types that did not change in the database (Apple configuration profiles, Windows configuration profiles, or Apple declarations).Demo video: https://www.loom.com/share/8b75cbd8e7394c12ac6b56746b72c244
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.