Skip to content

fix docker compose detection in fleetctl preview - #21006

Merged
roperzh merged 2 commits into
mainfrom
fix-fleetctl-preview
Aug 2, 2024
Merged

fix docker compose detection in fleetctl preview#21006
roperzh merged 2 commits into
mainfrom
fix-fleetctl-preview

Conversation

@roperzh

@roperzh roperzh commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

for #21007

CI that uses this is passing now https://github.com/fleetdm/fleet/actions/runs/10220076886/job/28279696099

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Manual QA for all new/changed functionality

@roperzh
roperzh marked this pull request as ready for review August 2, 2024 18:15
@roperzh
roperzh requested a review from a team as a code owner August 2, 2024 18:15

@lucasmrod lucasmrod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@roperzh
roperzh merged commit e7d56e9 into main Aug 2, 2024
@roperzh
roperzh deleted the fix-fleetctl-preview branch August 2, 2024 18:51
roperzh added a commit that referenced this pull request Aug 2, 2024
for #21007

CI that uses this is passing now
https://github.com/fleetdm/fleet/actions/runs/10220076886/job/28279696099

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
roperzh added a commit that referenced this pull request Aug 2, 2024
> [!NOTE]
> This the commits in this PR already merged in `main`. This is against
the release branch so it can be included in 4.55.0
@roperzh roperzh mentioned this pull request Aug 5, 2024
@lukeheath lukeheath mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants