API changes for #467 - #14456
Closed
rachaelshaw wants to merge 1 commit into
Closed
Conversation
fleet-release
approved these changes
Oct 11, 2023
rachaelshaw
temporarily deployed
to
Docker Hub
October 11, 2023 18:31 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
fleet-release
approved these changes
Oct 11, 2023
10 tasks
fleet-release
approved these changes
Oct 11, 2023
lucasmrod
reviewed
Oct 16, 2023
| "user_time_p50": 3.55, | ||
| "user_time_p95": 3.00, | ||
| "total_executions": 3920 | ||
| } |
Member
There was a problem hiding this comment.
Live queries have two APIs, one synchronous and one asynchronous.
The asynchronous one (in the "API for contributors") should be the one being amended for #467. Though the goal for #467 has since been reduced to only collect stats for saved queries when ran as live queries (no API changes), so maybe this PR is not valid anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes to REST API for issue #467
(My assumption is that query performance info comes from
stats, lmk if that's wrong!)