[josxha]

Main Issue:

• Fix [SPEC] Overhaul gesture system #1715

Current state of development:

Move gestures

• drag
• flingAnimation
• twoFingerMove (old: pinchMove)

Zoom gestures

• twoFingerZoom (old: pinchZoom)
• doubleTapZoomIn (old: doubleTapZoom)
• doubleTapDragZoom
• scrollWheelZoom
• trackpadZoom

Rotate gestures

• twoFingerRotate (old: rotate)
• ctrlDragRotate (old: hidden gesture)

Gesture callbacks

• onTap
• onLongPress
• onSecondaryTap
• onSecondaryLongPress (new)
• onTertiaryTap (new)
• onTertiaryLongPress (new)
• onPointerDown
• onPointerUp
• onPointerCancel
• onPointerHover

Changes along the way:

• rewrote FlutterMapInteractiveViewer as MapInteractiveViewer
• created gestures as objects
• remove PositionedTapDetector2
• add new callbacks for secondaryLongPress, tertiaryTap, tertiaryLongPress gestures
• fix [BUG] Double-tap-drag gesture doesn't cause new tiles to load after completion #1602
• fix [FEATURE] Revert to using single onPanUpdate to detect pan events #1729
• fix Scroll zoom does not stop ongoing fling and zoom animations #1767
• remove typdefs for PointerDownCallback, PointerUpCallback, PointerCancelCallback, PointerHoverCallback, MapEventCallback, IsKeyCursorRotationTrigger
• turn MoveAndRotateResult into a class
• Changed InteractionOptions.flags into InteractionOptions.enabledGestures that still supports flags
• Remove debugMultiFingerGestureWinner, enableMultiFingerGestureRace, rotationWinGestures, pinchMoveWinGestures and pinchZoomWinGestures (use case unclear)
• move directory /gestures to /map/gestures since it part of it
• rename InterativeFlagsPage to more general GesturesPage
• remove hidden gesture setNorthOnClick (press CTRL + click to rotate to 0°)
• remove CursorRotationBehaviour
• remove CursorKeyboardRotationOptions, merge gesture with EnabledGestures and keys option with InteractiveOptions
• Use more descriptive names for InteractiveFlags: pinchMove -> twoFingerMove, doubleTapZoom -> doubleTapZoomIn, rotate -> twoFingerRotate
• Remove MapEventSource.cursorKeyboardRotation in favor of ctrlDragRotateStart, ctrlDragRotateEnd and ctrlDragRotate

[josxha]

Marking this pull request as ready to review again.

Some thoughts:

• Touchpad (aka. Trackpad) rotate gesture to rotate the map hasn't been included because I'm not able to implement this without a Macbook. It could be that PointerPanZoomUpdateEvent.rotation provides the necessary rotation data but I can't tell.
• The two finger scroll gesture hasn't been included (is not supported on master either). It seems to me that this event gets turned into a pan gesture with a ScaleUpdateDetails.pointerCount of 1.
• Trackpad behaviour is extremely platform dependent. Web uses the legacy trackpad service, modern windows and macos devices use the new trackpad service.
• The legacy trackpad service doesn't zoom on the cursor but on the center on the map.

[JaffaKetchup]

Still untested, but here's review round 2 :D. Mostly just smaller stuff now, and there's less than it looks at first glance.
I would like for @mootw @TesteurManiak or @ibrierley to also review this PR, and any other community reviews also appricated! It's quite a big PR, so want to make sure I/we haven't missed anything.

[JaffaKetchup]

• One bug with cursor keyboard rotation. Rotation is not tracking the cursor properly. I remember having a similar issue when implementing the algorithm initially. Maybe double checking that nothing in the implementaiton itself has changed, and every variable is being changed/reset at the correct points.

• Cursor keyboard rotation also no longer sets rotation to the angle of cursor immediately when clicking.

2024-01-22.20-38-47.mp4

---

• One bug with fling event end/finished event not being emmitted (when fling is cancelled with tap (as shown in video), or when finished naturally)

2024-01-22.20-47-41.mp4

---

• Double tap zoom no longer emits correct event.

PR	Master
!

---

• Can no longer fling if drag gesture is disabled. On master, enabling fling without drag would start a fling if the normal conditions were met, but wouldn't drag/move if not, and wouldn't move whilst normal dragging.

---

• Double tap + drag gesture now loads tiles whilst zooming. master behaviour isn't correct either. The correct behaviour is that new tiles shouldn't load and old ones shouldn't be pruned whilst moving, and the refresh should occur when the gesture completes.

---

• On tap events and callbacks are no longer triggered.

---

• Can't seem to perform the new trackpad zoom gesture. Can you explain how to do it?

---

Still untested on any touch devices. Will perform that testing later.

[josxha]

Branch moved, see new pr here: #1809