Repository navigation
Migrate to null safety #829
Description
Activity
There are few blockers
flutter_image is deprecated and no longer maintained under Flutter org.
latlong is archived and is no longer maintained.
positioned_tap_detector has been discontinued
proj4dart is not yet migrated to sound null safety.For latlong here is active pull request
#750in order for migrating to Flutter 2.0 we will need this library to be null safe. This is a one of a kind package which lets Flutter community to use their beloved widgets as markers. @johnpryan do you have any strategy for this? @AyushBherwani1998 thanks for listing the deprecated dependencies. It might be a good starting point before nnbd migration. I think flutter_image and latlong are not going to be hard to replace. I don't know what proj4dart is for and if there is a replacement for positioned_tap_detector.
For "latlong".
What about "latlng" package ? (that is already null safety compatible)nb: I didn't check the code https://github.com/xclud/flutter_latlng.
Error: Cannot run with sound null safety, because the following dependencies don't support null safety: - package:flutter_map - package:latlong - package:logging - package:validate - package:proj4dart - package:tuple - package:positioned_tap_detector - package:flutter_image - package:quiver - package:mgrs_dart - package:wkt_parser - package:unicode - package:listsReacted by Szabó Gábor and Alexander GabrielIt looks like
latlongwas abandoned but someone has forked that and added Null Safety:
https://pub.dev/packages/latlong2Reacted by Gnuhry, attex, John Ryan, aytunc, Alexandros SIDIRAS and fvisticotlogging has been updated to null-safety
tuple has a prerelease for null-safety
quiver has been updated to null-safety
unicode has been updated to null-safetyI think this repo is archived and I'm gonna fork and publish NS version of flutter_map.
Reacted by aytunc, attex, Andrey and Luka Stillingfleet@arsamme thanks. But I do hope it is not the case for flutter_map. I see the owner @johnpryan active from time to time. I would love to hear his opinion about the future of this great package
@aytunch I hope too. But he didn't respond to any issue for a long time.
@arsamme @aytunch there's a call for maintainers on the top of the issues list on this repo. I assume someone else has to join as an active maintainer so that the package get's timel yupdates. Is there another package available out there or downgrading to pre-null-safety version is one of the ways you manage the production-ready apps ?
@o1dnik I have missed the call for maintainers issue, thanks for pointing it out. I have been using this library from the very early days. And lately @maRci002 and @lpongetti have done very useful and successful contributions among other developers. As now understanding that @johnpryan is busy with other stuff, I would like to know from you two friends if you have an agenda on this libraries null safety upgrade, maintenance and new features? Thanks.
Lastly, I would like to remind to the developers and marketers of several Map provider companies which are supported by this package that if this package is not maintained anymore, we would most likely change to another provider which offer similar functionality using their official packages. So it would be great to get some help from your side too:)
@aytunch I've submitted call for maintainers form and no answers yet (after about two weeks)
I am going to migrate proj4dart to nullsafety including mgrs_dart / wkt_parser packages.
Reacted by aytunc, Andrey, nik, Kenneth Gulbrandsøy, Stefan Anders, danilocubos and James HoGreat to hear from you @maRci002
I am just gathering the info scattered throughout this issue so we know where we are in terms of Null Safety status of Flutter_map's dependencies. Thanks everyone who shared info here (I haven't checked the packages, just collected the info in the issue so if there are new updates, please copy paste the table and reply accordingly):
-
✅ package:logging
-
✅ package:quiver
-
✅ package:unicode
-
✅ package:lists
-
✅ package:positioned_tap_detector (thanks to @arsamme)
-
♻️ package:tuple (prerelease null safety)
-
⚠️ package:proj4dart (on maRci002's radar) -
⚠️ package:mgrs_dart (on maRci002's radar) -
⚠️ package:wkt_parser (on maRci002's radar) -
❓package:latlong (https://pub.dev/packages/latlong2 someone has forked that and added Null Safety) There is an alternative package called latlng which has null safety also.
-
❓package:validate (looks like this is not a dependency: Migrate to null safety MikeMitterer/dart-validate#6 (comment))
-
❌ package:flutter_image (deprecated and no longer maintained under Flutter org)
Reacted by emallay, Gnuhry, Joscha Eckert, Ali Raghebi and Richard Vogel-
54 remaining items
See my comment on #894. I think we should wait for flutter_image 4.0.1, which is now part of flutter packages. The branch 829-nullsafety is now pointing to the new location in flutter packages.
When flutter_image 4.0.1 is published to pub.dev, I will merge it to master as soon at a contributor approves it (we can not merge our own PRs), and ask @johnpryan to release 0.13.0.
Reacted by aytuncThis is great news, and I'm glad to see some progress 👍 .
Should the new release be 1.0.0 (or 2.0.0) however? This is because this is a potentially breaking change with huge code refactoring, and it kind of seems time for a major release.
Caching should not be handled by the image provider like that. Check my post in #984 for info.
@JaffaKetchup it would likely be version 1.0.0. Any increase of the first number is indicating a significant breaking change.
FWIW I opened an issue to ask for flutter_image to be published: flutter/flutter#82900
Reacted by Marthijs Berfelo and aytuncAnd flutter_image v4.0.1 was published: flutter/flutter#82900 (comment)
Reacted by Rory Stephenson, Kenneth Gulbrandsøy, Luka Stillingfleet and aytuncI'll update the branch tonight @barbalex
@johnpryan We are ready to merge shortly. Can you do the review soon?
Reacted by Luka Stillingfleet, aytunc, Rory Stephenson, nazdream and Robin SchönauReacted by Alexander Gabriel and Rory StephensonReacted by Marthijs Berfelo and Luka Stillingfleet- added 3 commits that reference this issue
on May 19, 2021 Hi, are we ready for this? Hoping to get this done today or tomorrow so I can update my plugin 👍.
Reacted by aytunc and Ondrej SynacekStill looking forward for Null Safety solution :)
One of our side project uses this library, would be happy to help to migrate to null safety @johnpryan