fix(MESHCENT-008-2): child_process stdout accumulation uses ad-hoc .result property instead of the .str convention - #101
Draft
flamingo[bot] wants to merge 1 commit into
Draft
Conversation
…result` property instead of the `.str` convention
![flamingo[bot]](https://avatars.githubusercontent.com/in/3426709?s=60&v=4){kind=small}
Comment on lines
261
to
268
| else | ||
| { | ||
| this._checkpid = require('child_process').execFile('/bin/sh', ['sh']); | ||
| this._checkpid.stdout.result = ''; | ||
| this._checkpid.stdout.on('data', function (chunk) { this.result += chunk.toString(); }); | ||
| this._checkpid.stdout.str = ''; | ||
| this._checkpid.stdout.on('data', function (chunk) { this.str += chunk.toString(); }); | ||
| switch(platformType) | ||
| { | ||
| case 'init': |
Author
There was a problem hiding this comment.
🦩 🟠 child_process stdout accumulation uses ad-hoc .result property instead of the .str convention
In the run function's linux branch, renamed this._checkpid.stdout.result to this._checkpid.stdout.str at initialization and inside the 'data' event listener (this.str += chunk.toString()), and updated the two subsequent reads (this._checkpid.stdout.str != '' and parseInt(this._checkpid.stdout.str)) to match, aligning with the .str convention used in the darwin branch just below.
🤖 Prompt for AI agents
In modules/service-host.js around line 252, review and complete this code-review fix: child_process stdout accumulation uses ad-hoc `.result` property instead of the `.str` convention.
What the draft fix changed: In the `run` function's linux branch, renamed `this._checkpid.stdout.result` to `this._checkpid.stdout.str` at initialization and inside the 'data' event listener (`this.str += chunk.toString()`), and updated the two subsequent reads (`this._checkpid.stdout.str != ''` and `parseInt(this._checkpid.stdout.str)`) to match, aligning with the `.str` convention used in the darwin branch just below.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 92 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule MESHCENT-008-2 — child_process stdout accumulation uses ad-hoc
.resultproperty instead of the.strconvention.Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
.resultproperty instead of the.strconventionmodules/service-host.js:252What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
36292efa-450d-4316-bb92-99897b2455bdMerging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.