fix(FLEETMDM-010-2): Duplicate SVG gradient id 'fillPathId' generated once but used on two different <linearGradient> elements - #130
Draft
flamingo[bot] wants to merge 1 commit into
Conversation
… once but used on two different <linearGradient> elements
| @@ -5,6 +5,7 @@ import type { SVGProps } from "react"; | |||
| const Brave = (props: SVGProps<SVGSVGElement>) => { | |||
| const clipPathId = uniqueId("clip-path-"); | |||
Author
There was a problem hiding this comment.
🦩 🔴 Duplicate SVG gradient id 'fillPathId' generated once but used on two different elements
In Brave component, added a second uniqueId("fill-path-") call assigned to fillPathId2, applied it as the id of the second <linearGradient> element (the FF452A -> FF2000 gradient), and updated the third <path>'s fill attribute (previously url(#${fillPathId})) to reference url(#${fillPathId2}) so it correctly points to that gradient instead of colliding with the first one.
🤖 Prompt for AI agents
In frontend/pages/SoftwarePage/components/icons/Brave.tsx around line 6, review and complete this code-review fix: Duplicate SVG gradient id 'fillPathId' generated once but used on two different <linearGradient> elements.
What the draft fix changed: In `Brave` component, added a second `uniqueId("fill-path-")` call assigned to `fillPathId2`, applied it as the `id` of the second `<linearGradient>` element (the FF452A -> FF2000 gradient), and updated the third `<path>`'s `fill` attribute (previously `url(#${fillPathId})`) to reference `url(#${fillPathId2})` so it correctly points to that gradient instead of colliding with the first one.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule FLEETMDM-010-2 — Duplicate SVG gradient id 'fillPathId' generated once but used on two different elements.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
frontend/pages/SoftwarePage/components/icons/Brave.tsx:6What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
f6d23861-693f-45a1-b5b3-570aa3bc9ea7Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.