feat: implement Metrics for ng#968
Open
Pablu23 wants to merge 94 commits into
Open
Conversation
…s -> opensearch message_backlog_size: 1
…ssage_backlog_size: 2500
…s about queue sizes; add state reporting for terminal events
…n ng connector tests;fix non-ng tests
…opic; consolidate benchmark configs
Collaborator
Author
|
NG Benchmarks --num-events 500000 --ng 1 throughput (weighted): 3,339.43 docs/s
|
mhoff
reviewed
May 28, 2026
| logger = getLogger("Exporter") | ||
|
|
||
|
|
||
| def make_patched_asgi_app(functions: Iterable[Callable] | None) -> Callable: |
Collaborator
There was a problem hiding this comment.
Please make the Callable more specific with its generic type parameter where useful and applicable.
At least:
Suggested change
| def make_patched_asgi_app(functions: Iterable[Callable] | None) -> Callable: | |
| def make_patched_asgi_app(functions: Iterable[Callable[[], bool]] | None) -> Callable: |
Collaborator
|
tests/unit/ng/conftest.py |
1c27e21 to
84e213d
Compare
dcbbaea to
a6fa9d2
Compare
6baf5b4 to
04049e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement Metrics for async NG code
Assignee
Documentation
Code Quality
How did you verify that the changes work in practice?
Running benchmark script, and while that runs running
curl localhost:8081/metricsand parsing the output with my eyesReviewer
The rendered docs for this PR can be found here.