Conversation
de-vri-es
commented
Jun 16, 2024
Comment on lines
+23
to
+26
| * [`Template`]: borrows the source string. | ||
| * [`TemplateBuf`]: owns the source string. | ||
| * [`ByteTemplate`]: borrows the source bytes. | ||
| * [`ByteTemplateBuf`]: owns the source bytes. |
Contributor
Author
There was a problem hiding this comment.
Feel free to bikeshed over the naming.
dan-jfisher
reviewed
Jun 20, 2024
| } | ||
| } | ||
|
|
||
| /// Parse a braced variable in the form of "${name[:default]} from source at the given position. |
There was a problem hiding this comment.
Could you add an example of this to the README?
Contributor
Author
There was a problem hiding this comment.
Hmm? That's an internal function. Nobody can call it directly.
There was a problem hiding this comment.
I just meant this syntax: ${name[:default]}.
There was a problem hiding this comment.
Ah it's there already. I just can't read.
dan-jfisher
approved these changes
Jun 20, 2024
ekrikelis
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to re-use a parsed template string more than once.
To preserve backwards compatibility the error types are a little but duplicate now, but I think it's worth it to avoid breaking compatibility.
This can also be used by #18 to implement the different expansion modes without breaking the API.