Skip to content

Fce 3164/add moq endpoints#74

Merged
Karolk99 merged 5 commits intomainfrom
fce-3164/add-moq-endpoints
Apr 15, 2026
Merged

Fce 3164/add moq endpoints#74
Karolk99 merged 5 commits intomainfrom
fce-3164/add-moq-endpoints

Conversation

@Karolk99
Copy link
Copy Markdown
Collaborator

Description

  • OpenApi update
  • adds two methods to FishjamClient:
  • create_moq_publisher_token
  • create_moq_subscriber_token

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link
Copy Markdown

linear bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MoQ (Media over QUIC) token generation support to the Python Fishjam client by extending the generated OpenAPI client and exposing new convenience methods on FishjamClient.

Changes:

  • Introduces new OpenAPI client endpoints for creating MoQ publisher/subscriber tokens.
  • Adds FishjamClient.create_moq_publisher_token and FishjamClient.create_moq_subscriber_token.
  • Adds integration tests covering the new methods and unauthorized behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
fishjam/api/_fishjam_client.py Exposes new MoQ token methods on the public client API.
fishjam/_openapi_client/api/moq/create_moq_publisher_token.py Generated OpenAPI endpoint wrapper for publisher token creation.
fishjam/_openapi_client/api/moq/create_moq_subscriber_token.py Generated OpenAPI endpoint wrapper for subscriber token creation.
fishjam/_openapi_client/api/moq/__init__.py Adds the moq API package.
fishjam/_openapi_client/models/moq_token.py Adds the MoqToken response model.
fishjam/_openapi_client/models/__init__.py Exports MoqToken from the OpenAPI models package.
tests/test_room_api.py Adds tests for MoQ token generation and unauthorized errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread fishjam/api/_fishjam_client.py Outdated
Comment thread fishjam/api/_fishjam_client.py Outdated
Comment thread fishjam/api/_fishjam_client.py Outdated
Comment thread fishjam/api/_fishjam_client.py Outdated
@Karolk99 Karolk99 merged commit f38f92f into main Apr 15, 2026
13 of 21 checks passed
@Karolk99 Karolk99 deleted the fce-3164/add-moq-endpoints branch April 15, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants