Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the SDK to release 0.26.0 and updates the generated OpenAPI client code (via openapi-python-client), including modernized typing and safer URL construction for path parameters.
Changes:
- Bump package version to
0.26.0and update lockfile accordingly. - Upgrade
openapi-python-client(dev dependency) and refresh generated client/models for newer typing style (|unions,__future__annotations). - URL-encode path parameters in generated API endpoints and allow some request bodies to be omitted via
UNSET.
Reviewed changes
Copilot reviewed 59 out of 60 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates locked versions for the 0.26.0 release and new dev tooling constraints. |
| pyproject.toml | Bumps project version to 0.26.0 and updates dev dependency range for openapi-python-client. |
| fishjam/_openapi_client/types.py | Modernizes typing (PEP 604 unions) for shared OpenAPI client types. |
| fishjam/_openapi_client/models/web_rtc_metadata.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/viewer.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/viewer_token.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/viewer_details_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/track.py | Updates typing style and narrows exception handling in parsing helpers. |
| fishjam/_openapi_client/models/track_metadata.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/track_forwarding.py | Updates typing style for optional fields. |
| fishjam/_openapi_client/models/track_forwarding_info.py | Updates typing style for optional/nullable fields. |
| fishjam/_openapi_client/models/subscriptions.py | Adds __future__ annotations and simplifies imports. |
| fishjam/_openapi_client/models/subscribe_tracks_body.py | Adds __future__ annotations and simplifies imports. |
| fishjam/_openapi_client/models/streams_listing_response.py | Adds __future__ annotations and updates type hints for list elements. |
| fishjam/_openapi_client/models/streamer.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/streamer_token.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/streamer_details_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/stream.py | Adds __future__ annotations and modernizes union typing for optional fields. |
| fishjam/_openapi_client/models/stream_details_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/stream_config.py | Adds __future__ annotations and modernizes typing for config fields. |
| fishjam/_openapi_client/models/rooms_listing_response.py | Adds __future__ annotations and updates type hints for list elements. |
| fishjam/_openapi_client/models/room.py | Adds __future__ annotations and modernizes typing for optional fields. |
| fishjam/_openapi_client/models/room_details_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/room_create_details_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/room_create_details_response_data.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/room_config.py | Adds __future__ annotations and modernizes typing for config fields. |
| fishjam/_openapi_client/models/peer.py | Adds __future__ annotations, modernizes typing, and narrows exception handling in parsing helpers. |
| fishjam/_openapi_client/models/peer_refresh_token_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/peer_refresh_token_response_data.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/peer_options_web_rtc.py | Adds __future__ annotations and modernizes union typing. |
| fishjam/_openapi_client/models/peer_options_vapi.py | Adds __future__ annotations and modernizes union typing. |
| fishjam/_openapi_client/models/peer_options_agent.py | Adds __future__ annotations and modernizes union typing. |
| fishjam/_openapi_client/models/peer_metadata.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/peer_details_response.py | Adds __future__ annotations and updates type hints to non-quoted forms. |
| fishjam/_openapi_client/models/peer_details_response_data.py | Adds __future__ annotations and modernizes union typing for optional fields. |
| fishjam/_openapi_client/models/peer_config.py | Adds __future__ annotations and modernizes union typing for variant options. |
| fishjam/_openapi_client/models/error.py | Adds __future__ annotations to support unquoted forward references. |
| fishjam/_openapi_client/models/composition_info.py | Adds __future__ annotations and updates type hints for list elements. |
| fishjam/_openapi_client/models/agent_output.py | Adds __future__ annotations and modernizes union typing for optional fields. |
| fishjam/_openapi_client/client.py | Modernizes typing (PEP 604 unions) and clarifies timeout-related docstrings. |
| fishjam/_openapi_client/api/viewer/generate_viewer_token.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/viewer/delete_viewer.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/viewer/create_viewer.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/track_forwarding/create_track_forwarding.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/streamer/generate_streamer_token.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/streamer/delete_streamer.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/streamer/create_streamer.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/stream/get_stream.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/stream/get_all_streams.py | Modernizes return type hints. |
| fishjam/_openapi_client/api/stream/delete_stream.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/stream/create_stream.py | Allows omitting body via UNSET and modernizes return type hints. |
| fishjam/_openapi_client/api/room/subscribe_tracks.py | URL-encodes path params and allows omitting body via UNSET. |
| fishjam/_openapi_client/api/room/subscribe_peer.py | URL-encodes path params and modernizes union typing for optional query param. |
| fishjam/_openapi_client/api/room/refresh_token.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/room/get_room.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/room/get_all_rooms.py | Modernizes return type hints. |
| fishjam/_openapi_client/api/room/delete_room.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/room/delete_peer.py | URL-encodes path params and modernizes return type hints. |
| fishjam/_openapi_client/api/room/create_room.py | Allows omitting body via UNSET and modernizes return type hints. |
| fishjam/_openapi_client/api/room/add_peer.py | URL-encodes path params and allows omitting body via UNSET. |
Comments suppressed due to low confidence (4)
fishjam/_openapi_client/api/room/create_room.py:30
- When
bodyisUNSET, this request omits the JSON payload but still setsContent-Type: application/json. Consider only setting the Content-Type header when a JSON body is actually included (or explicitly send an empty JSON body) to avoid misrepresenting the request payload.
if not isinstance(body, Unset):
_kwargs["json"] = body.to_dict()
headers["Content-Type"] = "application/json"
_kwargs["headers"] = headers
fishjam/_openapi_client/api/stream/create_stream.py:30
- When
bodyisUNSET, this request omits the JSON payload but still setsContent-Type: application/json. Consider only setting the Content-Type header when a JSON body is actually included (or explicitly send an empty JSON body) to avoid misrepresenting the request payload.
if not isinstance(body, Unset):
_kwargs["json"] = body.to_dict()
headers["Content-Type"] = "application/json"
_kwargs["headers"] = headers
fishjam/_openapi_client/api/room/add_peer.py:34
- When
bodyisUNSET, this request omits the JSON payload but still setsContent-Type: application/json. Consider only setting the Content-Type header when a JSON body is actually included (or explicitly send an empty JSON body) to avoid misrepresenting the request payload.
if not isinstance(body, Unset):
_kwargs["json"] = body.to_dict()
headers["Content-Type"] = "application/json"
_kwargs["headers"] = headers
fishjam/_openapi_client/api/room/subscribe_tracks.py:35
- When
bodyisUNSET, this request omits the JSON payload but still setsContent-Type: application/json. Consider only setting the Content-Type header when a JSON body is actually included (or explicitly send an empty JSON body) to avoid misrepresenting the request payload.
if not isinstance(body, Unset):
_kwargs["json"] = body.to_dict()
headers["Content-Type"] = "application/json"
_kwargs["headers"] = headers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
097db52 to
3e29a52
Compare
PiotrWodecki
approved these changes
Apr 10, 2026
Karolk99
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)