Skip to content

Rename the recent uploaded recordings title to express that they belong to user #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canova merged 1 commit into from
Aug 16, 2022
Merged

Rename the recent uploaded recordings title to express that they belong to user #4186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions locales/en-US/app.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ Home--profiler-motto = Capture a performance profile. Analyze it. Share it. Make
Home--additional-content-title = Load existing profiles
Home--additional-content-content = You can <strong>drag and drop</strong> a profile file here to load it, or:
Home--compare-recordings-info = You can also compare recordings. <a>Open the comparing interface.</a>
Home--recent-uploaded-recordings-title = Recent uploaded recordings
Home--your-recent-uploaded-recordings-title = Your recent uploaded recordings

## IdleSearchField
## The component that is used for all the search inputs in the application.
Expand Down Expand Up @@ -305,9 +305,9 @@ ListOfPublishedProfiles--published-profiles-delete-button-disabled = Delete

ListOfPublishedProfiles--uploaded-profile-information-list-empty = No profile has been uploaded yet!

# This string is used below the 'Recent uploaded recordings' list section.
# This string is used below the 'Your recent uploaded recordings' list section.
# Variables:
# $profilesRestCount (Number) - Remaining numbers of the uploaded profiles which are not listed under 'Recent uploaded recordings'.
# $profilesRestCount (Number) - Remaining numbers of the uploaded profiles which are not listed under 'Your recent uploaded recordings'.
ListOfPublishedProfiles--uploaded-profile-information-label = See and manage all your recordings ({ $profilesRestCount } more)

# Depending on the number of uploaded profiles, the message is different.
Expand Down
4 changes: 2 additions & 2 deletions src/components/app/Home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,8 @@ class HomeImpl extends React.PureComponent<HomeProps, HomeState> {
<section>
{/* Recent recordings: right column */}
<h2 className="homeRecentUploadedRecordingsTitle protocol-display-xxs">
<Localized id="Home--recent-uploaded-recordings-title">
Recent uploaded recordings
<Localized id="Home--your-recent-uploaded-recordings-title">
Your recent uploaded recordings
</Localized>
</h2>
<ListOfPublishedProfiles limit={3} withActionButtons={false} />
Expand Down
4 changes: 2 additions & 2 deletions src/test/components/__snapshots__/Home.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ profile in ⁨Firefox⁩, then analyze it and share it with profiler.firefox.com
<h2
class="homeRecentUploadedRecordingsTitle protocol-display-xxs"
>
Recent uploaded recordings
Your recent uploaded recordings
</h2>
<list-of-published-profiles
limit="3"
Expand Down Expand Up @@ -345,7 +345,7 @@ However, existing profiles can be viewed in any modern browser.
<h2
class="homeRecentUploadedRecordingsTitle protocol-display-xxs"
>
Recent uploaded recordings
Your recent uploaded recordings
</h2>
<list-of-published-profiles
limit="3"
Expand Down