Update the load testing script to make it shorter - #547
Merged
julienw merged 1 commit intoFeb 21, 2025
Conversation
julienw
commented
Feb 20, 2025
|
|
||
| echo ">>> Run a load test operation: 200 clients during 5 minutes (3/3)" | ||
| molotov -w 200 -d 300 publish_short_requests.py | ||
| molotov -w 200 -d 150 publish_short_requests.py |
Contributor
Author
There was a problem hiding this comment.
Note: I kept all 3 runs because we might still have some hiccups on one of them sometimes. I actually got one today when running them. Running 3 times makes it clearer what is a hiccup and what is normal (usually it's 2 vs 1).
canova
approved these changes
Feb 20, 2025
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Indeed 30 minutes is too long. This looks good to me, thanks!
| molotov -w 200 -d 300 --ramp-up 60 publish_short_requests.py | ||
| molotov -w 200 -d 150 --ramp-up 60 publish_short_requests.py | ||
|
|
||
| echo ">>> Run a load test operation: 200 clients during 5 minutes (1/3)" |
Member
There was a problem hiding this comment.
Can we also update the comments that are referencing "5 minutes" here and below?
Contributor
Author
There was a problem hiding this comment.
Oh right, I wanted to do it and forgot !! Thanks for catching it
julienw
force-pushed
the
reduce-duration-of-load-testing
branch
from
February 21, 2025 10:01
d991481 to
037e9c6
Compare
julienw
enabled auto-merge (squash)
February 21, 2025 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last time we looked at it with @canova, I remembered we thought that the 5 minutes (an arbitrary duration I picked when I initially worked on that) were too long. So I reduced this to 2:30 minutes instead. This makes the duration for the entire script about 15 minutes instead of 30 minutes.
Please tell me what you think @canova !