Skip to content

fix: cryptic socket hang up error#10833

Draft
IzaakGough wants to merge 3 commits into
mainfrom
@invertase/fix-issue-8085
Draft

fix: cryptic socket hang up error#10833
IzaakGough wants to merge 3 commits into
mainfrom
@invertase/fix-issue-8085

Conversation

@IzaakGough

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the function discovery process by passing the admin server's child process to detectFromPort, allowing the discovery loop to fail fast and surface the process's exit code and stderr if it terminates prematurely. The Node and Python runtime delegates have been updated to support this, and a unit test was added to verify the behavior. The reviewer identified a critical issue where a clean but premature exit (code 0 or null) of the child process before discovery completes would cause the exitedWithError promise to remain pending indefinitely, resulting in an infinite busy-loop that consumes 100% CPU. It is recommended to reject the promise on any exit of the child process to prevent this.

Comment thread src/deploy/functions/runtimes/discovery/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants