fix: cryptic socket hang up error#10833
Conversation
There was a problem hiding this comment.
Code Review
This pull request improves the function discovery process by passing the admin server's child process to detectFromPort, allowing the discovery loop to fail fast and surface the process's exit code and stderr if it terminates prematurely. The Node and Python runtime delegates have been updated to support this, and a unit test was added to verify the behavior. The reviewer identified a critical issue where a clean but premature exit (code 0 or null) of the child process before discovery completes would cause the exitedWithError promise to remain pending indefinitely, resulting in an infinite busy-loop that consumes 100% CPU. It is recommended to reject the promise on any exit of the child process to prevent this.
No description provided.