Skip to content

Added a new auth_token property to AuthSession class#350

Merged
yinan-symphony merged 5 commits into
finos:mainfrom
broHeryk:main
Jan 17, 2025
Merged

Added a new auth_token property to AuthSession class#350
yinan-symphony merged 5 commits into
finos:mainfrom
broHeryk:main

Conversation

@broHeryk

Copy link
Copy Markdown
Collaborator

Description

The reason for opening this PR is missing the auth_token property (which is present in java BDK). There's no other way except calling internal(private) methods so it's useful to expose this token so it's accessible.

Checklist

  • Filled properly the description and dependencies, if any
  • Unit tests updated or added
  • Docstrings added or updated

added tests

fixed names

remove formating noise

remove formating from test
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jan 16, 2025

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

@yinan-symphony

Copy link
Copy Markdown
Contributor

@broHeryk since the repo has not been update since a while, some git actions are out of to date, pls update them.

@yinan-symphony yinan-symphony left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@yinan-symphony
yinan-symphony merged commit 9a621bd into finos:main Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants