AGNT-586 Add support for simplified key delivery#811
Merged
Conversation
FabienVSymphony
changed the title
vladokrsymphony
approved these changes
Nov 13, 2024
tzhao-symphony
approved these changes
Nov 13, 2024
|
|
||
| // OpenAPI code generation | ||
| def apiBaseUrl = "https://raw.githubusercontent.com/finos/symphony-api-spec/30fcab0fe6eaa26dcc46e7dc5909467332ec8d0d" | ||
| def apiBaseUrl = "https://raw.githubusercontent.com/FabienVSymphony/symphony-api-spec/refs/heads/AGNT-585/" |
Contributor
There was a problem hiding this comment.
this should be finos link
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| @Slf4j |
|
|
||
| import org.apiguardian.api.API; | ||
|
|
||
| @API(status = API.Status.INTERNAL) |
yinan-symphony
approved these changes
Nov 13, 2024
yinan-symphony
left a comment
yinan-symphony
left a comment
Contributor
There was a problem hiding this comment.
by adding java docs on the two new classes, we are good.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #[AGNT-585]
When simplified key delivery is enabled and agent is running a version >= 24.12 we stop retrieving the keymanager token. This allows the user to run bots on cloud where an on premise key manager is not available
Dependencies
We depend on finos/symphony-api-spec#199 being merged before we can merge this PR as we use the swagger definitions to generate our APIs