Repository navigation
Conversation
Such a simple thing manifested in no tag, all assets being uploaded to
the same release ("v" with no number) and a weirdly-computed release name.
Retain download as the default, though.
This could fail on an artifactory repo setup where the download is a virtual union repo and the upload is a constituent that doesn't contain the package, but some other constituent repo does contain the package. Maybe this should be an option?
stesla
approved these changes
Nov 5, 2025
stesla
left a comment
stesla
left a comment
There was a problem hiding this comment.
LGTM. I agree a warning would be a good idea.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an artifactory/split repo model publish failure that doesn't exist in the unitary model: the
--publishcommand checks to see if the package is already in the current repo list--which, in split-repo model happens to be the download repo. The change here is for publish to check the content of the upload repo.I think this solution is appropriate in this case. However, we might also consider adding a warning level check on the download repo as well, since for the artifactory repository design, a pre-existing presence of the same package on the download side might end up occluding a download of the package the user is trying to publish. Ideally, there'd be a way to figure out which of the constituent repositories was actually contributing the package, but AFAIK artifactory doesn't offer that feature.