[codex] Reposition website as a 3D asset pipeline tool - #274
Conversation
📝 WalkthroughWalkthroughUpdated website content and UI to shift messaging and visuals from Mixamo-focused animation merging toward a broader CI/CD-centric 3D asset pipeline: HTML metadata and JSON-LD updated, App.jsx restructured (new pipeline and mixamo sections, removed demo/comparison), data exports renamed and rewritten, and new pipeline-specific CSS added. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f63185fa3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| command: anim | ||
| input-file: assets/base.fbx | ||
| options: --merge assets/walk.fbx assets/run.fbx -o assets/merged.fbx` | ||
| scan: `# Preview workflow (actively evolving)\nqtmesh scan ./assets --fail-on error\nqtmesh scan ./assets --format sarif -o reports/qtmesh.sarif`, |
There was a problem hiding this comment.
The new pipelineExamples.scan snippet advertises --format sarif -o ..., but qtmesh scan only parses --sarif <path> (and --report <path>) in src/CLIPipeline.cpp; unsupported flags are ignored, so users copying this command will not actually produce a SARIF file. This is especially problematic for CI users expecting a report artifact from the documented pipeline command.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
website/src/App.jsx (1)
307-339: Add the Docker example here or remove Docker from the promise.This section now says the same workflow runs locally, in Docker, and in GitHub Actions, but the rendered examples only show local commands plus GitHub Actions. Since
pipelineExamples.dockeralready exists, either surface that card as part of the grid or trim the subtitle so the section doesn’t under-deliver on the new positioning.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@website/src/App.jsx` around lines 307 - 339, The subtitle claims the same workflow runs "locally, in Docker, and inside GitHub Actions" but the UI grid omits the Docker example; add a CodePanel for pipelineExamples.docker (e.g., CodePanel title="Docker" code={pipelineExamples.docker} label="docker") into the <div className={styles.codeGrid}> alongside the other CodePanel components, or alternatively update the Section.subtitle to remove "in Docker" so the text matches the shown examples; modify either the grid to include pipelineExamples.docker or the subtitle string in the Section call to resolve the mismatch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@website/index.html`:
- Around line 8-10: Update the meta description and related marketing copy
strings (the meta tag with name="description" and the other similar strings
referenced around lines 15-18, 27-30, 45-57) to temper claims about scan and
validation features by adding qualifiers such as "preview", "in progress", or
"experimental"; e.g., change phrases like "scan and validation workflows" to
"scan and validation (preview) workflows" or "experimental scan and validation
features" so search/social previews don't overpromise while preserving the rest
of the description.
In `@website/src/App.jsx`:
- Line 105: The primary CTA label uses recommendedStore and falls back to
hero.ctaPrimary which can say "Download Latest" while the button opens the
install modal; update the logic around primaryCtaLabel (and the OS-detection
path that sets recommendedStore/unknown-OS behavior) so the fallback label
matches the modal action or, alternatively, when OS is unknown route the button
to the releases page instead of opening the install modal; locate and change the
expression that computes primaryCtaLabel and the code that decides whether to
open the install-modal (the recommendedStore/OS-detection branch referenced near
primaryCtaLabel and the similar block around lines 225-232) to ensure label and
action are consistent.
In `@website/src/data/content.js`:
- Around line 84-91: The githubAction example in the pipelineExamples object
uses a mutable branch reference
("fernandotonon/QtMeshEditor/.github/actions/qtmesh@master"); update the
pipelineExamples.githubAction string to pin the action to an immutable full
commit SHA (replace `@master` with @<full-commit-sha>) so the example demonstrates
secure, deterministic usage—ensure you update the action ref inside the
githubAction value to the actual commit SHA for the qtmesh action.
---
Nitpick comments:
In `@website/src/App.jsx`:
- Around line 307-339: The subtitle claims the same workflow runs "locally, in
Docker, and inside GitHub Actions" but the UI grid omits the Docker example; add
a CodePanel for pipelineExamples.docker (e.g., CodePanel title="Docker"
code={pipelineExamples.docker} label="docker") into the <div
className={styles.codeGrid}> alongside the other CodePanel components, or
alternatively update the Section.subtitle to remove "in Docker" so the text
matches the shown examples; modify either the grid to include
pipelineExamples.docker or the subtitle string in the Section call to resolve
the mismatch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 73a8e309-cef2-476d-ba94-015a5bc5eac0
📒 Files selected for processing (4)
website/index.htmlwebsite/src/App.jsxwebsite/src/App.module.csswebsite/src/data/content.js
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@website/src/App.module.css`:
- Around line 528-530: The CSS rule hard-codes .codeGrid > :nth-child(6) to span
two columns causing an empty cell when the total number of CLI cards is even;
replace it with a conditional selector that only makes the last card full-width
when the total count is odd—e.g., replace .codeGrid > :nth-child(6) {
grid-column: span 2; } with .codeGrid > :last-child:nth-child(odd) {
grid-column: span 2; } and apply the same change where the duplicate rule
appears (the other occurrence noted in the comment) so the span only happens
when the last item is at an odd index.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f54bfb40-4b9a-4689-aeb2-7ca3f68dfe36
📒 Files selected for processing (4)
website/index.htmlwebsite/src/App.jsxwebsite/src/App.module.csswebsite/src/data/content.js
✅ Files skipped from review due to trivial changes (1)
- website/index.html
| .codeGrid > :nth-child(6) { | ||
| grid-column: span 2; | ||
| } |
There was a problem hiding this comment.
Avoid hard-coding :nth-child(6) for full-width spanning.
With 6 CLI cards (website/src/App.jsx Line 320-327), this rule leaves an empty cell before the full-width card on desktop. Make the span conditional on an odd total count instead.
💡 Suggested CSS tweak
-.codeGrid > :nth-child(6) {
+.codeGrid > :last-child:nth-child(odd) {
grid-column: span 2;
}
@@
- .codeGrid > :nth-child(6) {
+ .codeGrid > :last-child:nth-child(odd) {
grid-column: auto;
}Also applies to: 674-676
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@website/src/App.module.css` around lines 528 - 530, The CSS rule hard-codes
.codeGrid > :nth-child(6) to span two columns causing an empty cell when the
total number of CLI cards is even; replace it with a conditional selector that
only makes the last card full-width when the total count is odd—e.g., replace
.codeGrid > :nth-child(6) { grid-column: span 2; } with .codeGrid >
:last-child:nth-child(odd) { grid-column: span 2; } and apply the same change
where the duplicate rule appears (the other occurrence noted in the comment) so
the span only happens when the last item is at an odd index.
|
1 participant
Summary
What Changed
scan -> validate -> fix/optimize -> convert/ship)Notes on Scan Messaging
Validation
npm run build(website) passes successfullySummary by CodeRabbit
New Features
Updates