fix(validator): fix double-lock crash when pos and UV share the same vertex buffer

[fernandotonon]

Summary

• doValidate() locked the position vertex buffer, then immediately tried to lock the UV buffer — when positions and UVs are interleaved in the same hardware buffer (the common case for most mesh formats), this throws Ogre's "already locked" RuntimeAssertionException, crashing the app on all platforms.
• Fix: compare texElem->getSource() with posElem->getSource() before locking the UV buffer. If they share the same binding index, reuse the already-locked data pointer and vertex stride instead of locking again. The separate tbuf->unlock() is also skipped in the shared-buffer case to prevent a double-unlock.

Test plan

• Load any standard mesh (FBX, OBJ, GLTF) — these all use interleaved pos+UV buffers
• Select the mesh, expand "Mesh Validation", click "Run Validation"
• Verify results appear without crash on macOS, Windows, and Linux

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed UV validation to prevent redundant buffer locking when texture coordinates share the same data source as position information. The validator now reuses the existing buffer reference in these cases.

[coderabbitai]

Warning

Rate limit exceeded

@fernandotonon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 40 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 40 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e19872ff-4d6c-4941-a99d-9267a16633d9

📥 Commits

Reviewing files that changed from the base of the PR and between 8653bcb and b1bd9f9.

📒 Files selected for processing (8)

• .github/workflows/deploy.yml
• CLAUDE.md
• CMakeLists.txt
• src/CLIPipeline.cpp
• src/CLIPipeline.h
• src/CLIPipeline_test.cpp
• src/MeshValidator.cpp
• src/main.cpp

📝 Walkthrough

Walkthrough

The change fixes a double-locking issue in UV validation where texture coordinates and vertex positions share the same source buffer. When buffers are shared, the code reuses the already-locked vertex pointer instead of acquiring a separate lock, and conditionally skips unlocking to prevent errors.

Changes

Cohort / File(s)	Summary
UV Buffer Locking Fix src/MeshValidator.cpp	Updated doValidate() to detect when texture coordinate and position data share the same vertex buffer source. When shared, reuses the locked vertex pointer/stride instead of attempting to lock the buffer twice. Retains separate buffer locking behavior when UV data resides in a distinct buffer.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix mesh validation crash on Linux; add Sentry breadcrumbs #244 — Also modifies MeshValidator::doValidate() in the same file, potentially affecting buffer management logic and the doValidate method structure.

Poem

🐰 Two locks upon one buffer deep,
Would make our vertex data weep!
But now we peek before we grab,
And share the lock, no double dab.
A hop, a skip, one lock will do! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description includes a Summary section explaining the problem and solution, and a Test plan section. However, the description template requires 'Technical Details' with subsections like ':bug: Bugfixes', which are missing.	Add a 'Technical Details' section with ':bug: Bugfixes' subsection detailing the specific code changes (texElem->getSource() comparison, reusing locked pointer/stride, skipping unlock).
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main bugfix: preventing a double-lock crash when position and UV vertex buffers share the same source.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/mesh-validator-double-lock

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/MeshValidator.cpp`:
- Around line 202-203: The UV out-of-range check currently uses u < -10.f || u >
11.f (and similar for v), which skips values between 10 and 11; update the
conditional that increments totalOutOfRangeUV to use symmetric ±10 thresholds (u
< -10.f || u > 10.f and v < -10.f || v > 10.f) so any UV outside ±10 is counted;
locate and modify the conditional that refers to totalOutOfRangeUV in
MeshValidator.cpp and adjust both u and v comparisons accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 211aef15-ef0f-49f4-9932-2adbb6970ed4

📥 Commits

Reviewing files that changed from the base of the PR and between f51cec9 and 8653bcb.

📒 Files selected for processing (1)

• src/MeshValidator.cpp

[sonarqubecloud]

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
22.5% Coverage on New Code
5.1% Duplication on New Code

See analysis details on SonarQube Cloud