Fix Docker publish ordering: run after build-linux - #185
Merged
Conversation
The Docker publish job needs the .deb artifact from build-linux. Previously it was in a separate workflow that triggered on release but ran before the .deb was built, causing failures. - deploy.yml: add docker-publish job (needs: build-linux), downloads the linux-binaries artifact directly instead of from the release - docker-publish.yml: keep only workflow_dispatch for manual rebuilds from existing releases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo GitHub workflow files are modified to enhance Docker image publishing: a new job is added to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3 tasks
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy.ymlwithneeds: build-linuxso it runs after the.debis builtlinux-binariesartifact directly instead of trying to fetch from the release (which wasn't uploaded yet)docker-publish.ymltoworkflow_dispatchonly, for manual rebuilds from existing releasesWhy
The separate
docker-publish.ymltriggered onrelease: publishedbut ran concurrently with the build jobs, so the.debdidn't exist yet — causing the download to fail.Test plan
docker-publishjob runs afterbuild-linuxcompletesDocker Publish (Manual)workflow🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes