Skip to content

Fix Docker publish ordering: run after build-linux - #185

Merged
fernandotonon merged 1 commit into
masterfrom
fix/docker-publish-ordering
Mar 9, 2026
Merged

Fix Docker publish ordering: run after build-linux#185
fernandotonon merged 1 commit into
masterfrom
fix/docker-publish-ordering

Conversation

@fernandotonon

@fernandotonon fernandotonon commented Mar 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Moves the Docker publish job into deploy.yml with needs: build-linux so it runs after the .deb is built
  • The job downloads the linux-binaries artifact directly instead of trying to fetch from the release (which wasn't uploaded yet)
  • Converts docker-publish.yml to workflow_dispatch only, for manual rebuilds from existing releases

Why

The separate docker-publish.yml triggered on release: published but ran concurrently with the build jobs, so the .deb didn't exist yet — causing the download to fail.

Test plan

  • Create a release and verify docker-publish job runs after build-linux completes
  • Verify the Docker image is pushed to ghcr.io
  • Test manual dispatch of Docker Publish (Manual) workflow

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Chores
    • Added automated Docker image publishing to Docker Hub and GHCR following release events.
    • Updated release workflow to support manual image build triggering with version specification.

The Docker publish job needs the .deb artifact from build-linux.
Previously it was in a separate workflow that triggered on release
but ran before the .deb was built, causing failures.

- deploy.yml: add docker-publish job (needs: build-linux), downloads
  the linux-binaries artifact directly instead of from the release
- docker-publish.yml: keep only workflow_dispatch for manual rebuilds
  from existing releases

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Mar 9, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a67ba534-96b0-4f7f-8455-6187a80aa09f

📥 Commits

Reviewing files that changed from the base of the PR and between 5a7b34a and f2501c8.

📒 Files selected for processing (2)
  • .github/workflows/deploy.yml
  • .github/workflows/docker-publish.yml

📝 Walkthrough

Walkthrough

Two GitHub workflow files are modified to enhance Docker image publishing: a new job is added to deploy.yml for post-release Docker image publication, while docker-publish.yml is refactored to use manual dispatch instead of release triggers and simplifies tag computation logic.

Changes

Cohort / File(s) Summary
New Docker Publish Job
.github/workflows/deploy.yml
Introduces a post-release Docker image publication pipeline including artifact download, version extraction from .deb file, multi-registry push (GHCR and Docker Hub), image verification, and dynamic tag generation.
Docker Publish Workflow Updates
.github/workflows/docker-publish.yml
Changes trigger from release-based to manual dispatch; simplifies tag determination logic by removing release event handling; updates tag computation to conditionally append "latest" tag; conditions .deb download based on resolved tag; removes Docker Hub login gating and adds GITHUB_OUTPUT propagation for tag values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • fernandotonon/QtMeshEditor#184: Modifies docker-publish workflow to build and publish Docker images from release .deb with version extraction, buildx usage, and multi-registry pushing.

Poem

🐰 A workflow takes flight, from release to registry bright,
Docker images now dance, through GHCR's expanse,
Hub and verification aligned, automation refined! 🐳✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/docker-publish-ordering

Comment @coderabbitai help to get the list of available commands and usage tips.

@fernandotonon
fernandotonon merged commit f24465e into master Mar 9, 2026
9 of 11 checks passed
@fernandotonon
fernandotonon deleted the fix/docker-publish-ordering branch March 9, 2026 19:25
@coderabbitai coderabbitai Bot mentioned this pull request Mar 24, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant