feat/playlist-ext-note#40
Draft
jollyjoker992 wants to merge 2 commits into
Draft
Conversation
feralfile-bot
left a comment
Contributor
There was a problem hiding this comment.
Reviewers: 2 (approve: 0, comment: 0, request-changes: 2)
- src/utilities/ff1-device.ts:193-196 logs
requestBodyunconditionally before every cast. I re-checked this path: it changes CLI output for every send and can print the full inline DP-1 payload for local playlists, which is a user-visible regression and a data-leak risk. Both reviewers independently flagged this, so it should be removed or moved behind an explicit debug/verbose path. - The new coverage in tests/ff1-device-cast-request.test.ts only exercises
buildDisplayPlaylistCastRequestBody; it does not exercise the actual send wiring in index.ts:1019-1035 or src/main.ts:279-287 / src/main.ts:398-409. That leaves the URL-detection and argument-threading behavior unprotected, so a regression in how hosted sources becomeplaylistUrlwould slip through. Both reviewers called out this gap.
Overall verdict: request changes.
Contributor
|
Automated human review request for PR #40. Risk zone: yellow This PR needs targeted human review on the scoped areas below, not a full second pass of the whole PR.
|
feralfile-bot
left a comment
Contributor
There was a problem hiding this comment.
Reviewers: 2 (approve: 0, comment: 2, request-changes: 0)
- Missing end-to-end coverage for the new
playlistUrlwiring in both entry points. The helper itself is covered in tests/ff1-device-cast-request.test.ts, but the actual decision points that propagateplaylistUrllive in index.ts and the twosrc/main.tssend paths (lines 279-287, lines 398-409). Both reviewer reports independently flagged this same gap, and a regression in URL detection or argument propagation would still slip through without CLI-level coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send: cast hosted playlists by URL (live updates)
Summary
When
sendis used with an http(s) playlist URL, the CLI still loads and verifies the JSON locally, but the cast request sendsplaylistUrlso the FF1 device fetches the playlist instead of receiving inlinedp1_callJSON. Local file sends are unchanged and still embeddp1_call.Changes
playlistUrlthroughsendPlaylistToDevice/sendToDeviceand build the cast body withbuildDisplayPlaylistCastRequestBody.isPlaylistSourceUrlfrom the CLIsendcommand and frommain.tsinteractive flows.README,EXAMPLES,FUNCTION_CALLING) and note rebuildingdist/when using theff1shim.buildDisplayPlaylistCastRequestBody.Testing
tests/ff1-device-cast-request.test.tscovers inline vs URL cast body shape and validation.