chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus and vitest dependencies to specific preview versions and includes corresponding updates in the pnpm-lock.yaml file. Additionally, it introduces a pnpm-workspace.yaml file with release age settings. The reviewer correctly identified that these settings are invalid in pnpm-workspace.yaml and should instead be configured in an .npmrc file.
| minimumReleaseAge: 4320 | ||
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - '@voidzero-dev/*' |
There was a problem hiding this comment.
The minimumReleaseAge and minimumReleaseAgeExclude settings are not valid top-level keys for pnpm-workspace.yaml. According to the pnpm documentation, these are .npmrc settings (configured as minimum-release-age and minimum-release-age-exclude).
Furthermore, these settings are specific to pnpm and will not be recognized by npm or bun as suggested in the PR description. If this project is not a monorepo, the pnpm-workspace.yaml file is likely unnecessary and should be removed in favor of an .npmrc file.
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan