Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#4
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 19, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus and vitest dependencies to specific preview versions and includes corresponding updates in the pnpm-lock.yaml file. Additionally, it introduces a pnpm-workspace.yaml file with release age settings. The reviewer correctly identified that these settings are invalid in pnpm-workspace.yaml and should instead be configured in an .npmrc file.

Comment thread pnpm-workspace.yaml
Comment on lines +1 to +4
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- vite-plus
- '@voidzero-dev/*'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The minimumReleaseAge and minimumReleaseAgeExclude settings are not valid top-level keys for pnpm-workspace.yaml. According to the pnpm documentation, these are .npmrc settings (configured as minimum-release-age and minimum-release-age-exclude).

Furthermore, these settings are specific to pnpm and will not be recognized by npm or bun as suggested in the PR description. If this project is not a monorepo, the pnpm-workspace.yaml file is likely unnecessary and should be removed in favor of an .npmrc file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant