Skip to content

chore(deps): bump vite-plus to v0.2.2#30

Closed
fengmk2 wants to merge 4 commits into
mainfrom
vp-0.2.2
Closed

chore(deps): bump vite-plus to v0.2.2#30
fengmk2 wants to merge 4 commits into
mainfrom
vp-0.2.2

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jul 3, 2026

Copy link
Copy Markdown
Owner

🔗 Linked issue

N/A

🧭 Context

Keeps the toolchain current by moving to vite-plus v0.2.2. The bump also lets the cli build run through vp pack instead of a separate tsdown setup.

📚 Description

Pin vite-plus, vite (alias to @voidzero-dev/vite-plus-core) and vitest to the v0.2.2 commit build via a dedicated vite-plus catalog, referenced across deps and overrides.

  • Migrate the cli build from tsdown to vp pack (new cli/vite.config.ts, using deps.neverBundle to keep @lydell/node-pty external)
  • Add rolldown 1.1.4 as a devDependency, and ignore it in knip since it is only consumed as @nuxt/vite-builder's optional peer for the rolldown-powered build
  • Fix vue(no-dupe-keys) lint errors by aliasing imports that collided with prop names of the same name in Input/Base.vue (noCorrect, noPasswordManager) and Tooltip/Base.vue (offset)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the tsdown build tool with vite-plus in the CLI package, updates several dependencies (including vite and vitest) to use pnpm's catalog: feature, and defines a shared catalog in pnpm-workspace.yaml. The review feedback correctly points out a critical issue: since the CLI package now relies on vite-plus for its build script and configuration, vite-plus must be explicitly declared as a devDependency in cli/package.json to prevent build failures under pnpm's strict dependency isolation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread cli/package.json
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

e18e dependency analysis

No dependency warnings found.

@fengmk2
fengmk2 force-pushed the vp-0.2.2 branch 6 times, most recently from d5c05ef to 5c8cd98 Compare July 4, 2026 08:24
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@fengmk2
fengmk2 force-pushed the vp-0.2.2 branch 7 times, most recently from 248142c to 89884f8 Compare July 4, 2026 09:21
Pin `vite-plus`, `vite` (alias to `@voidzero-dev/vite-plus-core`) and
`vitest` to the v0.2.2 commit build across deps, overrides and catalogs.

- Migrate the cli build from `tsdown` to `vp pack` (new cli/vite.config.ts)
- Add `rolldown` 1.1.4 as a devDependency
- Fix vue(no-dupe-keys) lint errors by aliasing imports that collided with
  prop names of the same name in Input/Base.vue (noCorrect,
  noPasswordManager) and Tooltip/Base.vue (offset)
43081j and others added 3 commits July 5, 2026 11:04
Co-authored-by: graphieros <alec.lloyd.probert@gmail.com>
Co-authored-by: Alec Lloyd Probert <55991794+graphieros@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@fengmk2 fengmk2 closed this Jul 6, 2026
@fengmk2
fengmk2 deleted the vp-0.2.2 branch July 6, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants