Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the tsdown build tool with vite-plus in the CLI package, updates several dependencies (including vite and vitest) to use pnpm's catalog: feature, and defines a shared catalog in pnpm-workspace.yaml. The review feedback correctly points out a critical issue: since the CLI package now relies on vite-plus for its build script and configuration, vite-plus must be explicitly declared as a devDependency in cli/package.json to prevent build failures under pnpm's strict dependency isolation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
e18e dependency analysisNo dependency warnings found. |
d5c05ef to
5c8cd98
Compare
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
248142c to
89884f8
Compare
Pin `vite-plus`, `vite` (alias to `@voidzero-dev/vite-plus-core`) and `vitest` to the v0.2.2 commit build across deps, overrides and catalogs. - Migrate the cli build from `tsdown` to `vp pack` (new cli/vite.config.ts) - Add `rolldown` 1.1.4 as a devDependency - Fix vue(no-dupe-keys) lint errors by aliasing imports that collided with prop names of the same name in Input/Base.vue (noCorrect, noPasswordManager) and Tooltip/Base.vue (offset)
Co-authored-by: graphieros <alec.lloyd.probert@gmail.com> Co-authored-by: Alec Lloyd Probert <55991794+graphieros@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
🔗 Linked issue
N/A
🧭 Context
Keeps the toolchain current by moving to
vite-plusv0.2.2. The bump also lets the cli build run throughvp packinstead of a separatetsdownsetup.📚 Description
Pin
vite-plus,vite(alias to@voidzero-dev/vite-plus-core) andvitestto the v0.2.2 commit build via a dedicatedvite-pluscatalog, referenced across deps and overrides.tsdowntovp pack(newcli/vite.config.ts, usingdeps.neverBundleto keep@lydell/node-ptyexternal)rolldown1.1.4 as a devDependency, and ignore it in knip since it is only consumed as@nuxt/vite-builder's optional peer for the rolldown-powered buildvue(no-dupe-keys)lint errors by aliasing imports that collided with prop names of the same name inInput/Base.vue(noCorrect,noPasswordManager) andTooltip/Base.vue(offset)