Skip to content

PF-2417 Sanitize composite actions (and some cleanup)#444

Draft
jasaltvik wants to merge 7 commits into
mainfrom
PF-2417-sanitize-composite-actions
Draft

PF-2417 Sanitize composite actions (and some cleanup)#444
jasaltvik wants to merge 7 commits into
mainfrom
PF-2417-sanitize-composite-actions

Conversation

@jasaltvik
Copy link
Copy Markdown
Contributor

This PR sanitizes inputs/json in our composite actions.

This includes all composite actions under the actions directory.


Other changes:

  • Remove ${{ }} from if statements as they are unnecessary, and it is better to evaluate directly
  • The biggest update here is in the SBOM action, where we use jq (already installed in the GitHub runner) to sanitize arguments before using them
  • Remove extra whitespace
  • Trivy scan input validation had a bug with broken step summary output because of line breaks
  • The official ZAP scan action used within the zap-scan composite action does not have a scan_api input, so these were removed

Read https://github.com/felleslosninger/platform/blob/main/docs/pipeline/how-to/pipeline-testing.md on how to test. There is no specific section for composite actions testing, but you need to check where the action is used, and update the branch.

Test runs:

  • TBA

@jasaltvik jasaltvik requested a review from a team June 4, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant