PF-2417 Sanitize composite actions (and some cleanup)#444
Draft
jasaltvik wants to merge 7 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sanitizes inputs/json in our composite actions.
This includes all composite actions under the actions directory.
Other changes:
${{ }}fromifstatements as they are unnecessary, and it is better to evaluate directlyjq(already installed in the GitHub runner) to sanitize arguments before using themzap-scancomposite action does not have ascan_apiinput, so these were removedRead https://github.com/felleslosninger/platform/blob/main/docs/pipeline/how-to/pipeline-testing.md on how to test. There is no specific section for composite actions testing, but you need to check where the action is used, and update the branch.
Test runs: