PF-2416 Sanitize update image workflow#435
Open
jasaltvik wants to merge 3 commits into
Open
Conversation
jasaltvik
force-pushed
the
PF-2416-sanitize-update-image-workflow
branch
from
8b0891a to
dea0761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sanitizes inputs/json in the update image workflow that triggers after an image is built and pushed to ACR (main commit).
This includes
Other changes:
Check important image inputsstep as the variables are required and do not need to be validatedSet Dependabot As Jira IDstep checkedsteps.find-jira-id.outputs.match == '', but thefind-jira-idstep never creates that output 🤷 This means that condition was always evaluating to true. It is now removed so the logic makes senseSet Author Username, Name, and Emailstep is simplified with backwards compatibility (we still use GitHub email for everything)Read https://github.com/felleslosninger/platform/blob/main/docs/pipeline/how-to/pipeline-testing.md#cd-repo-image-update on how to test.
Test runs: