Repository navigation
fix(parser): keep a <button> inside <select> open - #2580
cruspy2004 wants to merge 1 commit into
Conversation
A customizable <select> may start with a <button>, but opening a button closed any open select. A button now leaves an open select alone and still closes the other form tags, including an open button. Fixes fb55#2579
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
[Medium impact] The PR appears safe to merge.
|
Fixes #2579
Opening a
<button>closed an open<select>, becausebuttonusedformTagsinopenImpliesClose, which includesselect. A customizable select may now start with a<button>(whatwg/html#10548), sobuttongets its own set: the form tags withoutselect.A button still closes an open
button,input,optionand the other form tags, as before. The new tests cover the issue's example and nested buttons.Summary by CodeRabbit
<button>inside<select>remains open until its explicit closing tag, preserving customizable select content.<button>still implicitly closes an already-open button.