Adding enum defaults and more USI AT switch tests - #610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 80.40% 80.48% +0.08%
==========================================
Files 22 22
Lines 3710 3710
==========================================
+ Hits 2983 2986 +3
+ Misses 727 724 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
| enum LinkStatus { | ||
| UP = 0; | ||
| LINK_STATUS_UNKNOWN = 0; |
There was a problem hiding this comment.
Why not just UNKNOWN? LINK_STATUS_ prefix seems redundant, and not coherent with the DOWN/UP entries. I think you might be struggling with the lack of a namespace for enum constants. I'd recommend something like https://github.com/grafnu/forch/blob/master/proto/shared_constants.proto -- so you can namespace effectivly. You should be able to make it largely transparent in Java by amending the import with the additional level.
No description provided.