Skip to content

Adding enum defaults and more USI AT switch tests - #610

Merged
henry54809 merged 18 commits into
faucetsdn:masterfrom
henry54809:feature/convert-switchtests
Aug 21, 2020
Merged

henry54809 merged 18 commits into
faucetsdn:masterfrom
henry54809:feature/convert-switchtests

Conversation

@henry54809

Copy link
Copy Markdown
Collaborator

No description provided.

@henry54809
henry54809 requested a review from grafnu August 21, 2020 17:56
@codecov

codecov Bot commented Aug 21, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #610 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   80.40%   80.48%   +0.08%     
==========================================
  Files          22       22              
  Lines        3710     3710              
==========================================
+ Hits         2983     2986       +3     
+ Misses        727      724       -3     
Flag Coverage Δ
#aux 74.28% <ø> (ø)
#base 75.95% <ø> (+0.05%) ⬆️
#dhcp 72.37% <ø> (ø)
#many 72.42% <ø> (+0.13%) ⬆️
#topo 72.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/runner.py 87.83% <0.00%> (+0.31%) ⬆️
daq/gateway.py 91.09% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63328b6...ce7c6b9. Read the comment docs.

Comment thread usi/src/main/proto/usi.proto Outdated

enum LinkStatus {
UP = 0;
LINK_STATUS_UNKNOWN = 0;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just UNKNOWN? LINK_STATUS_ prefix seems redundant, and not coherent with the DOWN/UP entries. I think you might be struggling with the lack of a namespace for enum constants. I'd recommend something like https://github.com/grafnu/forch/blob/master/proto/shared_constants.proto -- so you can namespace effectivly. You should be able to make it largely transparent in Java by amending the import with the additional level.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL

@henry54809
henry54809 merged commit 5a50a50 into faucetsdn:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants