Additional DHCP test part 2. Multisubnet test

[henry54809]

No description provided.

[codecov]

Codecov Report

Merging #539 into master will decrease coverage by 0.15%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   80.38%   80.22%   -0.16%     
==========================================
  Files          22       22              
  Lines        3727     3743      +16     
==========================================
+ Hits         2996     3003       +7     
- Misses        731      740       +9     

Flag	Coverage Δ
#aux	73.86% <22.22%> (-1.52%)	⬇️
#base	75.32% <22.22%> (-1.64%)	⬇️
#dhcp	70.31% <18.51%> (-1.67%)	⬇️
#many	71.91% <85.18%> (+0.04%)	⬆️
#modules	23.56% <14.81%> (-0.08%)	⬇️
#topo	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
daq/ipaddr_test.py	88.70% <82.60%> (-7.04%)	⬇️
daq/gateway.py	91.05% <100.00%> (+0.09%)	⬆️
daq/host.py	90.73% <100.00%> (-0.18%)	⬇️
daq/stream_monitor.py	87.50% <0.00%> (-0.84%)	⬇️
daq/topology.py	96.13% <0.00%> (-0.41%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6add8...339f430. Read the comment docs.

[grafnu]

is this really net_mask? Isn't the value "16"? That's not a netmask, that's a CIDR or some kind of prefix space.. "net_mask" typically refers to the full 255.255.0.0 form.

[henry54809]

What should it be named? prefix?

[grafnu]

"The number following the slash is the prefix length" https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#CIDR_blocks -- so, likely prefix_len

…

On Thu, Jul 16, 2020 at 2:28 PM henry54809 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In docker/include/networking_scripts/change_dhcp_range <#539 (comment)>: > @@ -0,0 +1,24 @@ +#!/bin/bash -e +# +# Dynamically change DHCP lease range, requires killing and restarting +# dnsmasq as per documentation (SIGHUP does not reload configuration file). +LOCAL_IF=${LOCAL_IF:-$HOSTNAME-eth0} + +range_start=$1 +range_end=$2 +net_mask=$3 What should it be named? prefix? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#539 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIEPD7O5JXSYL55IXGDE53R35WG7ANCNFSM4O4YWRRA> .

[henry54809]

Renamed to prefix_len. PTAL

"The number following the slash is the prefix length" https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#CIDR_blocks -- so, likely prefix_len
…
On Thu, Jul 16, 2020 at 2:28 PM henry54809 @.> wrote: @.* commented on this pull request. ------------------------------ In docker/include/networking_scripts/change_dhcp_range <#539 (comment)>: > @@ -0,0 +1,24 @@ +#!/bin/bash -e +# +# Dynamically change DHCP lease range, requires killing and restarting +# dnsmasq as per documentation (SIGHUP does not reload configuration file). +LOCAL_IF=${LOCAL_IF:-$HOSTNAME-eth0} + +range_start=$1 +range_end=$2 +net_mask=$3 What should it be named? prefix? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#539 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIEPD7O5JXSYL55IXGDE53R35WG7ANCNFSM4O4YWRRA .