Skip to content

feat: move /organisations to /organizations#200

Merged
Eomm merged 1 commit into
fastify:mainfrom
10xLaCroixDrinker:feature/rename-organisations
Jan 26, 2025
Merged

feat: move /organisations to /organizations#200
Eomm merged 1 commit into
fastify:mainfrom
10xLaCroixDrinker:feature/rename-organisations

Conversation

@10xLaCroixDrinker

Copy link
Copy Markdown
Contributor

Description

This PR moves the /organisations route to /organizations and adds a redirect from the old route to the new.

Related Issues

Related to discussion in fastify/fastify#5349

Check List

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Can we add a redirect somehow? cc @jsumners

@10xLaCroixDrinker

Copy link
Copy Markdown
Contributor Author

Do you mean a server side redirect?

There's a client side redirect added in the docusaurus config at lines 208-213

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners

Copy link
Copy Markdown
Member

lgtm

Can we add a redirect somehow? cc @jsumners

Yes, we can add a page rule in Cloudflare for this (though it will use up one of our three available).

@Eomm

Eomm commented Apr 10, 2024

Copy link
Copy Markdown
Member

We handle redirects here:

function manageRedirects({ existingPath, major, versions, versionsShipped, ignore = [] }) {

but: https://prowritingaid.com/organisation-vs-organization

and the previous website stands with organisations:
https://github.com/fastify/website-metalsmith/blob/master/src/website/content/organisations.md

@Eomm

Eomm commented Apr 25, 2024

Copy link
Copy Markdown
Member

Could you update the PR? we fixed the deploy to staging.

Plus: why we don't add a redirect from organizations to organisations instead?
this would ease the job

@gurgunday

Copy link
Copy Markdown
Member

It was because the website uses American English everywhere else

@Fdawgs

Fdawgs commented Jan 15, 2025

Copy link
Copy Markdown
Member

@10xLaCroixDrinker Could you do a rebase please, and we can get this over the line. 😸
We've got rid of most of the images from static/img/organisations.

@10xLaCroixDrinker

Copy link
Copy Markdown
Contributor Author

@Fdawgs sure thing! I can take care of that by EOD Monday

@10xLaCroixDrinker 10xLaCroixDrinker force-pushed the feature/rename-organisations branch from 9cb77dd to 928eaa0 Compare January 26, 2025 07:19
@Eomm Eomm merged commit 8a30cc9 into fastify:main Jan 26, 2025
@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/rename-organisations branch February 17, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants