Conversation
Member
|
Can you fix linting? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct
Follow-up to #331.
While investigating that issue I found that shouldCompress assumes type is always a string:
js
const data = mimedb[type.split(';', 1)[0].trim().toLowerCase()]
Any non-string value throws a TypeError there. Calling the function directly:
To be clear about scope: I could not reproduce this through an actual HTTP request on current main. Fastify appears to drop an array Content-Type before the onSend hook runs, so a non-string value never reaches shouldCompress on that path. I've posted the details in #331 — the originally reported crash does not seem reproducible on v9.2.0.
This PR is therefore a defensive guard rather than a crash fix: a single early return that makes the function's contract explicit and its behaviour consistent for any non-string input. The test covers the array Content-Type path end to end.
Happy to close this if you'd rather not add a guard for an unreachable path.