fix: preserve status and headers when compressing a Fetch Response - #420
Merged
Merged
Conversation
climba03003
approved these changes
Aug 4, 2026
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compressing a Fetch
Responsedrops its status code and headers.Fastify doesn't unwrap a
ResponsebeforeonSend- it does that afterwards inonSendEndandonly if the payload is still a
Response. We swap in the compressed stream before then, so thatnever runs and
reply.code()/reply.header()are never called.Practically this means
content-type,Cache-ControlandSet-Cookiedisappear and every statusbecomes 200.
Fix applies the status and headers when we take the body, same as
onSendEndwould have.This affects every tRPC v11 app using this plugin, since its Fastify adapter always sends a
Response, and those are streams so the threshold never skips them.Related issue: trpc/trpc#6628.
Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct