fix: make eject produce standalone applications - #924
Open
big-kahuna-burger wants to merge 1 commit into
Open
big-kahuna-burger wants to merge 1 commit into
big-kahuna-burger wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastify ejectcurrently requires an explicit--esmflag and leaves generated scripts and test helpers dependent onfastify-cli.This change detects ESM from
package.jsonand TypeScript fromsrc/app.ts, with explicit flags taking precedence. It updates generated scripts to run standalone servers, replaces unmodified generated test helpers, addsclose-with-graceas a runtime dependency, and removesfastify-cliwhen no scripts or source files still use it.TypeScript servers are generated under
src/and compiled todist/server.js. Generated TypeScript test scripts and configurations are updated to run compiled tests.Custom scripts, helpers, and TypeScript configurations are preserved. Customized server files are protected from overwriting, and the CLI dependency is retained when still needed.
Closes #683.
Validation
npm testsuite passes, including type tests and the 100% coverage gate.npm run lintpasses.fastify-cliinstalled.