chore: return to typescript v6.x - #221
Merged
Merged
Conversation
Member
|
I would say that we should update the shared workflows to ensure the linter fail do not trigger merging. |
Member
Author
Yes, I agree 😉👍🏻 let's hope |
4 tasks
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
I updated the TypeScript dependency to version 6.x, because
dependabothad updated the TypeScript dependency version to version 7.x, but this caused an error in lint sinceeslintv9 andneostandardare not compatible yet, making the pipeline red.Despite the CI being red, see here: 4858419 and https://github.com/fastify/busboy/actions/runs/29655747873/job/88109667826#step:5:1 dependabot merged the PR automatically.
Currently, major or automated updates to TypeScript can introduce breaking changes or type mismatches with our current linting setup (specifically with
eslint,neostandard, and related plugins likets-api-utils), causing commands likenpm run lint:fixto fail with runtime type errors.By ignoring it for now, we ensure that TypeScript updates are handled manually and verified alongside the rest of the linting toolchain.
cc @fastify/leads @fastify/libraries