Skip to content

馃摑 Fix formatting for help link to support GitHub-specific overview edge-case - #1826

Merged
svlandeg merged 1 commit into
fastapi:masterfrom
phalberg:master
Jun 8, 2026
Merged

馃摑 Fix formatting for help link to support GitHub-specific overview edge-case#1826
svlandeg merged 1 commit into
fastapi:masterfrom
phalberg:master

Conversation

@phalberg

@phalberg phalberg commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Based on
Discussion: #1794

Description

Changed the link of help-typer in contributions.md to handle GitHub overview edge case, where the link would come to a 404 error when clicked (since it resolved to the wrong location).

AI Disclaimer

I did not use AI in the process of making this PR.

AI transcript

Checklist

  • This PR is an obvious typo fix, or it links to a GitHub Discussion for the proposed code change.
  • I added tests for the change.
  • The new or updated tests fail on the main branch and pass on this PR.
  • Coverage stays at 100%.
  • The documentation explains the change if needed.

@github-actions github-actions Bot added the docs Improvements or additions to documentation label Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

馃摑 Docs preview

Last commit a746bff at: https://99595fba.typertiangolo.pages.dev

Modified Pages

@svlandeg svlandeg changed the title Fix: help link formatting for GitHub-specific overview edge-case 馃摑 Fix formatting for help link to support GitHub-specific overview edge-case Jun 8, 2026

@svlandeg svlandeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Also appreciate you going through the discussion forum first before making a PR. Everything has already been discussed there so this is good to merge now 馃帀

@svlandeg
svlandeg merged commit ba3dc50 into fastapi:master Jun 8, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants