馃悰 Ensure that hidden commands are not shown when Rich markup is disabled - #1812
Merged
Conversation
svlandeg
changed the title
None
svlandeg
marked this pull request as ready for review
June 1, 2026 14:23
svlandeg
changed the title
None
tiangolo
approved these changes
Jun 1, 2026
tiangolo
left a comment
tiangolo
left a comment
Member
There was a problem hiding this comment.
Excellent, thank you! 馃檶
This will be avaiable in the next few hours in Typer 0.26.5 馃殌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion: #1795, reported by @igor47.
Description
Hidden commands were shown when Rich formatting was turned off. This is a regression from Typer 0.26.0 which vendored Click, more specifically the bug was introduced by PR 1680. There were no relevant unit tests for this specific functionality, as most tests have Rich enabled.
I took the liberty to update an existing unit test "test_corner_cases" and gave it a more descriptive name "test_hidden" to test both a hidden option (existing test) as well as hidden commands (new tests).
AI Disclaimer
Used Cursor to help me debug the issue and write the first draft of the unit test. Reviewed and rewritten the test manually.
Checklist