Skip to content

refactor: rename Exn::from_iter to raise_all#33

Merged
tisonkun merged 1 commit into
fast:mainfrom
andylokandy:raise-all
Jan 17, 2026
Merged

refactor: rename Exn::from_iter to raise_all#33
tisonkun merged 1 commit into
fast:mainfrom
andylokandy:raise-all

Conversation

@andylokandy

Copy link
Copy Markdown
Contributor

No description provided.

@andylokandy andylokandy requested a review from tisonkun January 17, 2026 05:50

@tisonkun tisonkun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any additional background for this rename?

@andylokandy

Copy link
Copy Markdown
Contributor Author

Any additional background for this rename?

  1. Align the error argument order with Exn::new and Exn::raise, where the new error layer stays on the left.
  2. Make the raise sematic more obvious.

@tisonkun

Copy link
Copy Markdown
Contributor

Sounds reasonable!

@tisonkun tisonkun merged commit 3179a17 into fast:main Jan 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants