refactor: add ErrorExt#27
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
Seems conflicts with 1ffa557. But the questions stay valid. |
tisonkun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refers to #20.
cc @Byron I'll appreciate it if you can summarize the gap between this patch and your requirment on an error lib so that we can see if it's desired to use
exndirectly ingix-error.I've adjust the trait bound as
std::error:Error + Send + Syncand restore theraiseErrorExt.But I'm a bit hesitated about a type-erased top-level error and I'm considering how to make the (default) format impls more flexible. Initially, I'd prefer users to define their own display logics as in the
custom-layoutexample, because I don't likeerror-stack's global hooks which make initialization and reasoing too hard.