refactor!: remove exn::Error#23
Merged
Merged
Conversation
tisonkun
reviewed
Jan 14, 2026
tisonkun
reviewed
Jan 14, 2026
tisonkun
approved these changes
Jan 15, 2026
tisonkun
left a comment
tisonkun
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
@andylokandy shall we release a 0.3.0 after this patch merged? Or we may cut a 0.3.0-rc.0 for testing first.
andylokandy
commented
Jan 15, 2026
| /// ``` | ||
| #[expect(non_snake_case)] | ||
| pub fn Ok<T, E: Error + 'static>(value: T) -> Result<T, E> { | ||
| pub fn Ok<T, E: std::error::Error + 'static>(value: T) -> Result<T, E> { |
Contributor
Author
There was a problem hiding this comment.
Should we use std::error::Error to keep consistent?
Contributor
There was a problem hiding this comment.
This is in the lib.rs, so I'd make an exception to avoid use crate::Error, an alias to std::error:Error, which can cause more ambiguity.
Perhaps we can move this function to a new file and pub use it at lib.rs, while use std::error::Error in that file. But let's do it later?
Contributor
|
I'll merge this now and release a |
Contributor
|
Failed to compile due to |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.