Repository navigation
fix(locale): fix postcodes and add missing province for id_ID - #4272
Open
insanrizky wants to merge 1 commit into
Open
insanrizky wants to merge 1 commit into
insanrizky wants to merge 1 commit into
Conversation
Indonesian postal codes are five digits from 10110 to 99xxx and never start with 0, but the `#####` pattern produced a leading 0 in about 10% of results. Also add Papua Barat Daya, the 38th province (est. 2022). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
ST-DDT
added
p: 1-normal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #4272 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 1180 1180
Lines 3977 3977
Branches 723 723
=======================================
Hits 3943 3943
Misses 29 29
Partials 5 5 🚀 New features to boost your workflow:
|
matthewmayer
approved these changes
Nov 14, 2026
ST-DDT
approved these changes
Nov 14, 2026
ST-DDT
enabled auto-merge
November 14, 2026 08:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indonesian postal codes have five digits from 10110 to 99xxx and never start with 0 (e.g.
10110Jakarta Pusat,40111Bandung,80111Denpasar). Theid_IDpattern#####gives a leading 0 in about one in ten results: with seed 42, 975 of 10000fakerID_ID.location.zipCode()results (v10.6.0) start with 0. This replaces it with1####…9####, the same approach asde_ATandne.The
id_IDstate list also had only 37 of the 38 provinces: Papua Barat Daya (split from Papua Barat in 2022) was missing. This adds it.I did not add a test because the allowed formats are visible in the data file. The
locale-datasnapshot is unchanged (no new characters).Verification:
oxfmt --list-different0.75.0 passes on the changed files; 10000 zip codes generated from the new patterns contain 0 with a leading 0 and 0 that are not five digits;pnpm run preflightpasses.AI-assisted and reviewed by me.